rule: add union_now_doc_hidden
#679
Conversation
| pub union MyUnion { | ||
| f1: u32, | ||
| f2: f32, | ||
| } |
There was a problem hiding this comment.
nitpick: could you ensure all files have trailing newline characters? You should be able to adjust your editor to add them automatically when you save.
There was a problem hiding this comment.
I've never seen cargo.toml as the filename for this, I've only ever seen Cargo.toml (note the capitalization difference).
I'm curious how you generated this file — did you use the scripts for creating new lints and test files? Are you using a filesystem that lowercases everything?
There was a problem hiding this comment.
For some reason Cargo.toml is not generated after running the script but all other files do. My bad I named it wrongly.
There was a problem hiding this comment.
Oh interesting, that sounds like a bug in the script that we should fix. Which script did you have this experience with?
There was a problem hiding this comment.
Running ./scripts/regenerate_test_rustdocs.sh also gives the error,
cargo-semver-checks/scripts/regenerate_test_rustdocs.sh: line 23: shopt: globstar: invalid shell option name
There was a problem hiding this comment.
After commenting out line no 23 it works fine.
There was a problem hiding this comment.
Ah can you check which shell and which version of that shell you're using? globstar was introduced in bash 4 (released 15 years ago!) but some systems still only have bash 3 by default =/
Our scripts should probably check the shell version and exit with an error if it's too old. If you're open to writing and testing that kind of PR on your machine, I'd be thrilled to merge it — I'm not able to because all my computers are updated to use bash 5.
There was a problem hiding this comment.
Oh interesting, that sounds like a bug in the script that we should fix. Which script did you have this experience with?
make_new_lint.sh
There was a problem hiding this comment.
Opened #680 for this, feel free to tackle it if you find it interesting! Our tooling gets better one small improvement at a time — it really adds up over the course of weeks and months.
|
Looks like this lint can be unified too with |
Yeah, lots of lints can be unified like that. At this stage that's predominantly a cosmetic improvement, though, so having the lint in any form is better than trying to squeeze everything into as few lints as possible. |
obi1kenobi
added
A-lint
Part of #578