Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New lint: pub fn becomes unsafe #191

Closed
Tracked by #5
obi1kenobi opened this issue Nov 23, 2022 · 0 comments · Fixed by #226
Closed
Tracked by #5

New lint: pub fn becomes unsafe #191

obi1kenobi opened this issue Nov 23, 2022 · 0 comments · Fixed by #226
Labels
A-lint Area: new or existing lint E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.

Comments

@obi1kenobi
Copy link
Owner

obi1kenobi commented Nov 23, 2022 •
edited
Loading

If a public function becomes unsafe, that's a breaking change: uses of that function now require an unsafe block.

We already have the necessary schema for this, so this just needs the lint query and a test case.
@obi1kenobi obi1kenobi mentioned this issue Nov 23, 2022
Open
@obi1kenobi obi1kenobi added A-lint Area: new or existing lint E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue. labels Nov 23, 2022
@obi1kenobi obi1kenobi changed the title pub fn becomes unsafe New lint: pub fn becomes unsafe Nov 23, 2022
@obi1kenobi obi1kenobi mentioned this issue Dec 14, 2022
Merged
4 tasks
obi1kenobi added a commit that referenced this issue Dec 17, 2022
@obi1kenobi
Add lints for adding unsafe to methods and functions.
b306507 
Resolves #191.
@obi1kenobi obi1kenobi mentioned this issue Dec 17, 2022
Merged
obi1kenobi added a commit that referenced this issue Dec 17, 2022
@obi1kenobi
Add lints for adding unsafe to methods and functions. (#226)
c756bc2 
Resolves #191.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: new or existing lint E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add lints for adding unsafe to methods and functions. obi1kenobi/cargo-semver-checks
1 participant
@obi1kenobi