-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement /dev/sbl_srv file #605
Conversation
We should probably initialize all the /dev devices somewhere inside the module. |
Better to split each device into a separated module like |
All of the devices in the |
@ultimaweapon I think I already asked this somewhere, but you may have overlooked it. Aren't all the Cdevsws static in FreeBSD? I don't really see a reason for Arc here |
I can't remember why I was chosen for the current solution. But I already thought about static but decided to use Arc instead. Maybe we can try converted to a static version and see if we hit any problems. |
@SuchAFuriousDeath can you check if your issues has been fixed? |
I think @mikusp already fixed that. |
Oh 👀 Then by all means, merge this |
@@ -25,7 +25,7 @@ pub use self::perm::*; | |||
pub use self::stat::*; | |||
pub use self::vnode::*; | |||
|
|||
mod dev; | |||
pub mod dev; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not need to be public anymore.
Gid::ROOT, | ||
Mode::new(0o600).unwrap(), | ||
None, | ||
MakeDev::MAKEDEV_ETERNAL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is not this one is zero here?
Superseded by #729 |
If there is a way to avoid making
dev
mod pub, let me know in suggestions.