Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement /dev/sbl_srv file #605

Closed
wants to merge 2 commits into from
Closed

Implement /dev/sbl_srv file #605

wants to merge 2 commits into from

Conversation

mikusp
Copy link
Contributor

@mikusp mikusp commented Feb 3, 2024

If there is a way to avoid making dev mod pub, let me know in suggestions.

@SuchAFuriousDeath
Copy link
Contributor

We should probably initialize all the /dev devices somewhere inside the module.

@SuchAFuriousDeath SuchAFuriousDeath requested a review from a team February 3, 2024 23:42
@ultimaweapon
Copy link
Member

We should probably initialize all the /dev devices somewhere inside the module.

Better to split each device into a separated module like dev/dmem0 will be a responsible of DmemManager.

@ultimaweapon
Copy link
Member

All of the devices in the src/kernel/src/fs/dev are legacy ones. It is a remnant of the old FS system. That means we are going to move all of them to the outside like TtyManager.

@SuchAFuriousDeath
Copy link
Contributor

SuchAFuriousDeath commented Feb 5, 2024

@ultimaweapon I think I already asked this somewhere, but you may have overlooked it. Aren't all the Cdevsws static in FreeBSD? I don't really see a reason for Arc here

@ultimaweapon
Copy link
Member

@ultimaweapon I think I already asked this somewhere, but you may have overlooked it. Aren't all the Cdevsws static in FreeBSD? I don't really see a reason for Arc here

I can't remember why I was chosen for the current solution. But I already thought about static but decided to use Arc instead. Maybe we can try converted to a static version and see if we hit any problems.

@ultimaweapon
Copy link
Member

@SuchAFuriousDeath can you check if your issues has been fixed?

@SuchAFuriousDeath
Copy link
Contributor

Depends on whether you're fine with merging this
image

@ultimaweapon
Copy link
Member

I think @mikusp already fixed that.

@SuchAFuriousDeath
Copy link
Contributor

SuchAFuriousDeath commented Feb 24, 2024

Oh 👀 Then by all means, merge this

@@ -25,7 +25,7 @@ pub use self::perm::*;
pub use self::stat::*;
pub use self::vnode::*;

mod dev;
pub mod dev;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not need to be public anymore.

Gid::ROOT,
Mode::new(0o600).unwrap(),
None,
MakeDev::MAKEDEV_ETERNAL,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is not this one is zero here?

@SuchAFuriousDeath
Copy link
Contributor

Superseded by #729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants