Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly implement the TIOCSCTTY ioctl #795

Open
SuchAFuriousDeath opened this issue Apr 1, 2024 · 4 comments
Open

Properly implement the TIOCSCTTY ioctl #795

SuchAFuriousDeath opened this issue Apr 1, 2024 · 4 comments
Labels
T-enhancement Type: Enhancement

Comments

@SuchAFuriousDeath
Copy link
Contributor

SuchAFuriousDeath commented Apr 1, 2024

This is a standard FreeBSD ioctl. I decided to conciously skip it for now, because:

  1. The code would be really messy with a lot of .read() and .write() and .unwrap
  2. We would have to use Weak pointers to prevent memory leaks, causing even more unwraps
  3. It doesn't produce any output or affect any internal state that affects anything else (as far as we know)
  4. previously,before the filesystem rework, this was also skipped and nothing bad happened.

Under these circumstances, I believe it's justifiable to postpone the implementation of this until it is required.
We already got stuck on the filesystem for such a long time and I don't want to get stuck on this right now.

@SuchAFuriousDeath SuchAFuriousDeath pinned this issue Apr 1, 2024
@gandalfthewhite19890404 gandalfthewhite19890404 added the T-enhancement Type: Enhancement label Apr 3, 2024
@SuchAFuriousDeath SuchAFuriousDeath closed this as not planned Won't fix, can't repro, duplicate, stale Apr 7, 2024
@SuchAFuriousDeath
Copy link
Contributor Author

This is not needed anymore after #810

@SuchAFuriousDeath SuchAFuriousDeath unpinned this issue Apr 7, 2024
@ultimaweapon
Copy link
Member

This one is going to be needed when we supports running the PS4 firmware so I'll re-open this.

@ultimaweapon ultimaweapon reopened this Apr 8, 2024
@SuchAFuriousDeath
Copy link
Contributor Author

When do you intend to begin working on that, if I may ask?

@ultimaweapon
Copy link
Member

Once I finished migrating the game to run inside a VM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-enhancement Type: Enhancement
Development

No branches or pull requests

3 participants