Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement console ioctl with com = 0x20007461 #525

Closed
SuchAFuriousDeath opened this issue Dec 16, 2023 · 20 comments
Closed

Implement console ioctl with com = 0x20007461 #525

SuchAFuriousDeath opened this issue Dec 16, 2023 · 20 comments
Assignees
Labels
T-enhancement Type: Enhancement

Comments

@SuchAFuriousDeath
Copy link
Contributor

Now that we know what it is, it should be fairly easy.

@gandalfthewhite19890404 gandalfthewhite19890404 added the T-enhancement Type: Enhancement label Dec 18, 2023
@SuchAFuriousDeath
Copy link
Contributor Author

@ultimaweapon Actually, do we really need to implement this? Probably not, right?

@ultimaweapon
Copy link
Member

We should implement everything that we can.

@SuchAFuriousDeath
Copy link
Contributor Author

Right. But currently this just mutates some sort of an internal state and then nothing touches that state again (at least yet). So right now, implementing this doesn't help us at all.

@ultimaweapon
Copy link
Member

If there are other things we can do and it has more priority than this one then do that one first.

@SuchAFuriousDeath SuchAFuriousDeath self-assigned this Dec 23, 2023
@SuchAFuriousDeath
Copy link
Contributor Author

SuchAFuriousDeath commented Dec 23, 2023

@ultimaweapon Now that we know what the console is... maybe we should create a separate window with a terminal for it?

@ultimaweapon
Copy link
Member

If you are willing to work with Qt.

@SuchAFuriousDeath
Copy link
Contributor Author

Maybe later :D

@SuchAFuriousDeath
Copy link
Contributor Author

And what if just the kernel were running?

@ultimaweapon
Copy link
Member

It's just a normal stderr.

@SuchAFuriousDeath
Copy link
Contributor Author

SuchAFuriousDeath commented Dec 23, 2023

By the way, wouldn't it be better to create sort of a wrapper type for all the strings that are actually arrays in FreeBSD? We could use const generics. It would be faster and more explicit and may even prevent us from making some mistake in the future.

@ultimaweapon
Copy link
Member

Good idea. I think there should be a crate for this so better to check first.

@SuchAFuriousDeath
Copy link
Contributor Author

I found arraystring, but the documentation says that it's not using const generics.

@ultimaweapon
Copy link
Member

Seems like we need to implement this by our self.

@SuchAFuriousDeath
Copy link
Contributor Author

By the way, after syscall 602, what's the game doing for you? The same as before? Mine is doing this:
image

@ultimaweapon
Copy link
Member

That is an expected behavior.

@SuchAFuriousDeath
Copy link
Contributor Author

I thought so, just making sure

@SuchAFuriousDeath
Copy link
Contributor Author

SuchAFuriousDeath commented Dec 23, 2023

By the way, is there a reason or threads don't have a proc field, like FreeBSD?

@ultimaweapon
Copy link
Member

Because we only have one proc so no point to put it there.

@SuchAFuriousDeath
Copy link
Contributor Author

The reason I'm asking is that passing a &Arc to Dmem1 felt really weird

@SuchAFuriousDeath
Copy link
Contributor Author

Superseded by #795

@SuchAFuriousDeath SuchAFuriousDeath closed this as not planned Won't fix, can't repro, duplicate, stale Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-enhancement Type: Enhancement
Development

No branches or pull requests

3 participants