Added version check for bash version gteq 4 #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelSpeed
previously approved these changes
Oct 21, 2019
There was a problem hiding this comment.
Haven't directly tested this but had a play with ${BASH_VERSINFO} in my shell (didn't know it was a thing!) and it looks like this should work well, thanks for the fix @jmfrank63
I think adding a note to the changelog would be good if you have a moment to do so?
loshz
previously approved these changes
Oct 21, 2019
JoelSpeed
reviewed
Oct 28, 2019
CHANGELOG.md
Outdated
| @@ -232,3 +232,4 @@ v2.2 as released by Bitly. | |||
| - Repository forked on 27/11/18 | |||
| - README updated to include note that this repository is forked | |||
| - CHANGLOG created to track changes to repository from original fork | |||
| - Added bash >= 4.0 dependency to configure script | |||
There was a problem hiding this comment.
Sorry, this should be of the format:
- [#292](https://github.com/pusher/oauth2_proxy/pull/292) Added bash >= 4.0 dependency to configure script (@jmfrank63)
And should be at the top of this file with the more recent changes (changes since v4.0.0)
loshz
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #291
Motivation and Context
How Has This Been Tested?
I ran configure against bash version <4. The script fails with the reported error.
I then upgraded to bash version 5 via homebrew.
As a result the script ran fine.
I uninstalled bash again falling back to the native OSX version.
I ran configure again resulting in:
This script requires Bash version >= 4After reinstalling bash via homebrew again the script did work again.
Checklist:
I am not yet fully confident of the style on a CHANGELOG entry. I am willing to do the change but would like some guidance.