Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure username for Redis cluster connections #2381

Merged
merged 4 commits into from
Jan 20, 2024
Merged

Add ability to configure username for Redis cluster connections #2381

merged 4 commits into from
Jan 20, 2024

Conversation

rossigee
Copy link
Contributor

@rossigee rossigee commented Jan 10, 2024

Description

This PR adds the ability to configure username for Redis cluster connections.

Motivation and Context

Addresses #2020 where users need to authenticate to their Redis clusters with usernames (other than 'default') but are otherwise unable to configure it as such.

How Has This Been Tested?

  • Tested using a new test cases based on the existing 'password-only' test cases.
  • Tested in my local cluster using an actual Redis Cluster with username authentication.

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.
  • I have written tests for my code changes.

@rossigee rossigee requested a review from a team as a code owner January 10, 2024 10:05
Copy link
Member

@tuunit tuunit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuunit tuunit added the LGTM PR is ready to merge label Jan 10, 2024
JoelSpeed
JoelSpeed previously approved these changes Jan 20, 2024
@JoelSpeed JoelSpeed merged commit f3dbca6 into oauth2-proxy:master Jan 20, 2024
6 checks passed
@rossigee rossigee deleted the fix-username-auth-to-redis-cluster branch January 20, 2024 23:37
tuunit added a commit to tuunit/oauth2-proxy that referenced this pull request Jan 21, 2024
* enhancement: Change base image from alpine to distroless (oauth2-proxy#2295)

* Changed base image from alpine to distroless

* chore: updated Makefile

* fix: removed arm/v6 and ppc64le for distroless variant

* Update Dockerfile

* Update Makefile

* docs: Add README-section, CHANGELOG-entry and --pull to prevent caching

---------

Co-authored-by: Joel Speed <[email protected]>

* Add possibility to encode the state param as UrlEncodedBase64 (oauth2-proxy#2312)

* Add possibility to encode the state param as UrlEncodedBase64

* Update CHANGELOG.md

* Update oauthproxy.go

Co-authored-by: Jan Larwig <[email protected]>

---------

Co-authored-by: Jan Larwig <[email protected]>

* NGINX return 403 for sign_in (oauth2-proxy#2322) (oauth2-proxy#2323)

Co-authored-by: Sven Ertel <[email protected]>

* chore: Create sha256sum for tar instead of binary (oauth2-proxy#2343)

* Create sha256sum for tar instead of binary

* chore: Add checksum for binary

* chore: Updated changelog

---------

Co-authored-by: Joel Speed <[email protected]>

* Log error details when failed loading CSRF cookie (oauth2-proxy#2345)

* Log error details when failed loading CSRF cookie

* Add a record about this PR to CHANGELOG.md

---------

Co-authored-by: Ondrej Charvat <[email protected]>
Co-authored-by: Joel Speed <[email protected]>

* Feature - Add env variable support for alpha struct (oauth2-proxy#2375)

* added envsubstring package and added simple test cases.imple tests.

* added documentation

* added changelog entry

* added documentation to wrong file


.

* changed tests to ginkgo format

* update project to use better maintained library

* use defer to clear test variable after tests finished

* updated docs for the new package documentation and fixed bad english

* refactored function to "reduce" complexity.

* updated changelog for new version

updated readme

* minor formatting

---------

Co-authored-by: Haydn Evans <[email protected]>
Co-authored-by: Joel Speed <[email protected]>

* remove nsswitch workaround (oauth2-proxy#2371)

Co-authored-by: Joel Speed <[email protected]>

* feat: Added renovate configuration (oauth2-proxy#2377)

* Feature/add option to skip loading claims from profile url (oauth2-proxy#2329)

* add new flag skip-claims-from-profile-url

* skip passing profile URL if SkipClaimsFromProfileURL

* docs for --skip-claims-from-profile-url flag

* update flag comment

* update docs

* update CHANGELOG.md

* Update providers/provider_data.go

Co-authored-by: Jan Larwig <[email protected]>

* Add tests for SkipClaimsFromProfileURL

* simplify tests for SkipClaimsFromProfileURL

* generate alpha_config.md

---------

Co-authored-by: Jan Larwig <[email protected]>

* Add ability to configure username for Redis cluster connections (oauth2-proxy#2381)

* Initial attempt.

* Add CHANGELOG entry.

* Drop commented-out Sentinel test.

---------

Co-authored-by: Joel Speed <[email protected]>

* chore(deps): update module golang.org/x/crypto to v0.17.0 [security] (oauth2-proxy#2400)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update github.com/ghodss/yaml digest to d8423dc (oauth2-proxy#2401)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Improved dev environment (oauth2-proxy#2211)

* Improved dev env setup

* Cleanup duplicate checks

* Applied PR feedback

* Updated go.mod/go.sum

* go mod tidy

* Update .devcontainer/devcontainer.json

* Update pkg/http/server_test.go

Co-authored-by: Jan Larwig <[email protected]>

* Create launch.json

* Update .devcontainer/Dockerfile

* Apply suggestions from code review

---------

Co-authored-by: Jan Larwig <[email protected]>

* feature: add release automation workflows (oauth2-proxy#2224)

* feature: add release automation workflows

* deactivate provenancee because of behaviour change with buildx v0.10.0

* add changelog section extraction for github release notes

* fix registry path; fix EOF

* use correct version of golangci-lint; add additional workflow step for fetching all dependencies

* chore(deps): update module github.com/bsm/redislock to v0.9.4 (oauth2-proxy#2406)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* initial commit for docusaurus 3 upgrade

* fix mdx errors

* fix mdx issues

* fix routing issues

* update docs generation workflow

* fix version

* fix permissions

* move slack to header

* remove background color and minify

* Update docs/docs/configuration/providers/openid_connect.md

Co-authored-by: Koen van Zuijlen <[email protected]>

* Update docs/docs/configuration/providers/openid_connect.md

Co-authored-by: Koen van Zuijlen <[email protected]>

* Update docs/docs/configuration/providers/openid_connect.md

Co-authored-by: Koen van Zuijlen <[email protected]>

* Update docs/docs/configuration/providers/gitlab.md

Co-authored-by: Koen van Zuijlen <[email protected]>

* Update docs/docs/configuration/providers/gitlab.md

Co-authored-by: Koen van Zuijlen <[email protected]>

* Update docs/docs/configuration/providers/github.md

Co-authored-by: Koen van Zuijlen <[email protected]>

* Update docs/docs/configuration/providers/github.md

Co-authored-by: Koen van Zuijlen <[email protected]>

* Update docs/docs/configuration/providers/github.md

Co-authored-by: Koen van Zuijlen <[email protected]>

* Update docs/docs/configuration/providers/github.md

Co-authored-by: Koen van Zuijlen <[email protected]>

---------

Co-authored-by: Koen van Zuijlen <[email protected]>
Co-authored-by: Joel Speed <[email protected]>
Co-authored-by: Jan Brezina <[email protected]>
Co-authored-by: WhiteRabbit-Code <[email protected]>
Co-authored-by: Sven Ertel <[email protected]>
Co-authored-by: charvadzo <[email protected]>
Co-authored-by: Ondrej Charvat <[email protected]>
Co-authored-by: Haydn Evans <[email protected]>
Co-authored-by: Nils Gustav Stråbø <[email protected]>
Co-authored-by: Ross Golder <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants