Added arch types to Docker and binary releases #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvanzuijlen
changed the title
tuunit
requested changes
Sep 7, 2023
Co-authored-by: Jan Larwig <[email protected]>
Co-authored-by: Jan Larwig <[email protected]>
Co-authored-by: Jan Larwig <[email protected]>
Assuming this is about the Makefile; I renamed it back to arm64 since that's likely what caused the issue described in #2218. |
JoelSpeed
reviewed
Sep 7, 2023
@JoelSpeed I think that should still work, at least based on my own test: |
|
@JoelSpeed Tested it with the latest changes I just pushed |
JoelSpeed
previously approved these changes
Sep 8, 2023
JoelSpeed
approved these changes
Sep 8, 2023
flobeier
pushed a commit
to flobeier/oauth2-proxy
that referenced
this pull request
Oct 18, 2023
* Added several arm builds to dist.sh * Added platforms to Dockerfile and updated docs * Reverted changes made for testing * Fix docker platform images * Fix docker platform images * Update Makefile Co-authored-by: Jan Larwig <[email protected]> * Update Makefile Co-authored-by: Jan Larwig <[email protected]> * Update Makefile Co-authored-by: Jan Larwig <[email protected]> * Formatting improvements --------- Co-authored-by: Jan Larwig <[email protected]>
isodude
pushed a commit
to isodude/oauth2-proxy
that referenced
this pull request
Nov 7, 2023
* Added several arm builds to dist.sh * Added platforms to Dockerfile and updated docs * Reverted changes made for testing * Fix docker platform images * Fix docker platform images * Update Makefile Co-authored-by: Jan Larwig <[email protected]> * Update Makefile Co-authored-by: Jan Larwig <[email protected]> * Update Makefile Co-authored-by: Jan Larwig <[email protected]> * Formatting improvements --------- Co-authored-by: Jan Larwig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds build outputs for darwin-arm64, linux-armv5 and linux-armv7
Motivation and Context
Fixes #2219
Fixes #2218
How Has This Been Tested?
Ran
make releaselocally. All release artifacts were generated succesfully.Checklist: