-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added arch types to Docker and binary releases #2220
Added arch types to Docker and binary releases #2220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we keep armv7 and armv8? why did you remove armv8?
Co-authored-by: Jan Larwig <[email protected]>
Co-authored-by: Jan Larwig <[email protected]>
Co-authored-by: Jan Larwig <[email protected]>
Assuming this is about the Makefile; I renamed it back to arm64 since that's likely what caused the issue described in #2218. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change we are no longer pushing the latest
tags for anything, I don't think that's a desired change is it?
@JoelSpeed I think that should still work, at least based on my own test: |
@JoelSpeed Tested it with the latest changes I just pushed |
* Added several arm builds to dist.sh * Added platforms to Dockerfile and updated docs * Reverted changes made for testing * Fix docker platform images * Fix docker platform images * Update Makefile Co-authored-by: Jan Larwig <[email protected]> * Update Makefile Co-authored-by: Jan Larwig <[email protected]> * Update Makefile Co-authored-by: Jan Larwig <[email protected]> * Formatting improvements --------- Co-authored-by: Jan Larwig <[email protected]>
* Added several arm builds to dist.sh * Added platforms to Dockerfile and updated docs * Reverted changes made for testing * Fix docker platform images * Fix docker platform images * Update Makefile Co-authored-by: Jan Larwig <[email protected]> * Update Makefile Co-authored-by: Jan Larwig <[email protected]> * Update Makefile Co-authored-by: Jan Larwig <[email protected]> * Formatting improvements --------- Co-authored-by: Jan Larwig <[email protected]>
Description
Adds build outputs for darwin-arm64, linux-armv5 and linux-armv7
Motivation and Context
Fixes #2219
Fixes #2218
How Has This Been Tested?
Ran
make release
locally. All release artifacts were generated succesfully.Checklist: