Fix docker container multi arch build issue by passing GOARCH details to make build #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeeva Kandasamy <[email protected]>
|
Would you please add a changelog entry and then I can merge this? Thanks for the fast fix! |
jkandasa
changed the title
Signed-off-by: Jeeva Kandasamy <[email protected]>
|
@JoelSpeed I have updated the changelog. Kindly review the PR |
k-jell
pushed a commit
to liquidinvestigations/oauth2-proxy
that referenced
this pull request
Apr 6, 2022
… to make build (oauth2-proxy#1445) * pass GOARCH details to make process Signed-off-by: Jeeva Kandasamy <[email protected]> * update changelog Signed-off-by: Jeeva Kandasamy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jeeva Kandasamy [email protected]
Description
Resolves: #1442
How Has This Been Tested?
Tested it locally and the dockers images are available in https://quay.io/repository/jkandasa/oauth2-proxy?tab=tags
Checklist: