Skip to content

Disabled bsc specific features#154

Merged
ironbeer merged 18 commits intooasysgames:feat/merge-bsc-v1.5.13from
ironbeer:feat/merge-bsc-v1.5.13_del_bsc_features
Jun 11, 2025
Merged

Disabled bsc specific features#154
ironbeer merged 18 commits intooasysgames:feat/merge-bsc-v1.5.13from
ironbeer:feat/merge-bsc-v1.5.13_del_bsc_features

Conversation

@ironbeer
Copy link
Copy Markdown
Collaborator

@ironbeer ironbeer commented Jun 8, 2025

#150 の差分からブロックタイム0.75秒化関連の変更を無効化する修正

関連するBSCプロポーザル
BEP-563
BEP-564

@ironbeer ironbeer changed the title Disabled bsc specific features WIP: Disabled bsc specific features Jun 8, 2025
@ironbeer ironbeer changed the title WIP: Disabled bsc specific features Disabled bsc specific features Jun 9, 2025
@ironbeer ironbeer marked this pull request as ready for review June 9, 2025 01:27
@ironbeer ironbeer requested a review from tak1827 June 9, 2025 01:31
log.Debug("Propagated block", "hash", hash, "recipients", len(transfer), "duration", common.PrettyDuration(time.Since(block.ReceivedAt)))
// check if the block should be broadcast to more peers in EVN
var morePeers []*ethPeer
// if h.needFullBroadcastInEVN(block) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここら辺は消したいです。
needFullBroadcastInEVNqueryValidatorNodeIDsMap

}

// waitForSyncAndMaxwell waits for the node to be fully synced and Maxwell fork to be active
func (s *Ethereum) waitForSyncAndMaxwell(oasys *oasys.Oasys) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これは消したいです。
stopChupdateNodeID, handleRemovals, handleAdditions

panic("should not happen")
// add onchain validator p2p node list later, it will enable the direct broadcast + no tx broadcast feature
// here check & enable peer broadcast features periodically, and it's a simple way to handle the peer change and the list change scenarios.
// h.peers.enableEVNFeatures(h.queryValidatorNodeIDsMap(), h.evnNodeIdsWhitelistMap)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こんな感じで、コメントアウトするよりは enableEVNFeaturesを消したいです。
EVN系の変数は全消しでいいと思ってます。
こことか、こことか、こことか

@tak1827
Copy link
Copy Markdown
Contributor

tak1827 commented Jun 10, 2025

ここを削除しておいてください🙏

ここも僕らに合わせて変えておきますか。20に。

@ironbeer
Copy link
Copy Markdown
Collaborator Author

ここを削除しておいてください🙏

ここも僕らに合わせて変えておきますか。20に。

修正しました

@ironbeer ironbeer merged commit 8eac5fd into oasysgames:feat/merge-bsc-v1.5.13 Jun 11, 2025
@ironbeer ironbeer deleted the feat/merge-bsc-v1.5.13_del_bsc_features branch June 11, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants