Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explode common #16

Merged
merged 3 commits into from
Feb 26, 2021
Merged

explode common #16

merged 3 commits into from
Feb 26, 2021

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Feb 25, 2021

this is a draft to see what it would be like.

separate them to have their own prefixes/modules based on the Go codebase's detailed breakdown of the 'common' directory.
I kinda don't like it. but it may be more sustainable if we end up having types with the same name in different 'common' subpackages.

also tries out removing duplicate parts of names, e.g. CommonNode -> NodeNode -> Node.
I kinda don't like that either. seems like we had done this in the Go codebase with things like consensus.Parameters instead of consensus.ConsensusParameters. we had a lint for it, formerly known as 'stutter' rust-lang/rust-clippy#3521. I personally would have preferred rule simplicity and consistency across packages and longer name (consensus.ConsensusParameters) over the lint rule's more complex rule, less consistency across packages, and shorter name (consensus.Parameters). viva HTMLHtmlElement too

oh and this causes us to have a cbor module while our actual cbor helpers are in misc. hm

@pro-wh pro-wh requested a review from kostko February 25, 2021 22:40
@pro-wh
Copy link
Contributor Author

pro-wh commented Feb 26, 2021

let's go ahead with the type name changes, but not the module changes.

@pro-wh pro-wh merged commit fd36732 into pro-wh/feature/master Feb 26, 2021
@pro-wh pro-wh deleted the pro-wh/feature/common branch February 26, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant