Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a draft to see what it would be like.
separate them to have their own prefixes/modules based on the Go codebase's detailed breakdown of the 'common' directory.
I kinda don't like it. but it may be more sustainable if we end up having types with the same name in different 'common' subpackages.
also tries out removing duplicate parts of names, e.g.
CommonNode
->NodeNode
->Node
.I kinda don't like that either. seems like we had done this in the Go codebase with things like
consensus.Parameters
instead ofconsensus.ConsensusParameters
. we had a lint for it, formerly known as 'stutter' rust-lang/rust-clippy#3521. I personally would have preferred rule simplicity and consistency across packages and longer name (consensus.ConsensusParameters
) over the lint rule's more complex rule, less consistency across packages, and shorter name (consensus.Parameters
). vivaHTMLHtmlElement
toooh and this causes us to have a
cbor
module while our actual cbor helpers are inmisc
. hm