ci: debug-insecure-cipher-paratime -> localnet-cipher-paratime #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
insecure-debug-cipher-paratime.orctolocalnet-cipher-paratime.orcfor consistency with other ParaTime releases.Some thoughts
The prefix
localnet-implies it is to be run locally e.g. for testing, inside the CI, docker image etc. The incentive for this originated from EVM that uses the notion of chain ID and is baked in the Emerald and Sapphire ParaTime binary. On the client side MetaMask uses the chain ID to determine which web3 gateway IP it will try to connect to. So we decided that the localnet's chain ID will be the one pointing to 127.0.0.1. This way you change the behavior of your dApp by simply changing the chain ID in the config and then deployment, tests etc. will use a different network.Cipher does not have the chain ID notion. In theory, could you use the insecure Cipher binary to set up a perfectly valid non-confidential oasis-wasm chain on the network? In this case the
localnet-term may be less suitable. How does a Cipher dApp know which network to use? The combination of gRPC endpoing address + the Runtime ID? But the Runtime ID is not baked into the binary, right?