Use codehash when deriving addresses#181
Merged
Merged
Conversation
nhynes
force-pushed
the
use-codehash-address
branch
from
d0b5571 to
975fee2
Compare
nhynes
force-pushed
the
use-codehash-address
branch
from
e055c20 to
eb20389
Compare
nhynes
commented
Feb 20, 2020
nhynes
commented
Feb 20, 2020
eauge
approved these changes
Feb 20, 2020
This was referenced Feb 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
FromSaltAndCodeHashthe default address scheme for c10l contractsconfidiential: boolin the deploy header tosalt_if_confidential: Option<Salt>tl;dr: for c10l contracts, the address becomes a MAC of the code. The address is generated from the salt, and codehash. The salt is provided as part of the deploy header (
salt_if_confidential) or explicitly by aCREATE2call (and Wasmcreate, when it exists). This PR is useful for preventing subbing out the contract code at an address with a different contract.