Conversation
benchmark/src/main.rs
Outdated
| fn eth_blockNumber(client: &mut Web3Client<HttpHandle>) { | ||
| let res = client.eth_blockNumber().call(); | ||
| debug!("result: {:?}", res); | ||
| info!("result: {:?}", res); |
There was a problem hiding this comment.
This should be debug
benchmark/src/main.rs
Outdated
| .eth_getBlockByNumber("latest".to_string(), true) | ||
| .call(); | ||
| debug!("result: {:?}", res); | ||
| info!("result: {:?}", res); |
There was a problem hiding this comment.
Also should stay debug
benchmark/src/main.rs
Outdated
| number: usize, | ||
| ) { | ||
| info!("Starting {} benchmark...", name); | ||
| debug!("Starting {} benchmark...", name); |
benchmark/src/main.rs
Outdated
| let total = counter.load(Ordering::SeqCst); | ||
| let duration = end - start; | ||
| info!( | ||
| debug!( |
| use jsonrpc_core::{BoxFuture, Result}; | ||
| use jsonrpc_macros::Trailing; | ||
|
|
||
| use log; |
gateway/src/impls/eth.rs
Outdated
| measure_counter_inc!("sendRawTransaction"); | ||
| measure_histogram_timer!("sendRawTransaction_time"); | ||
| info!("eth_sendRawTransaction(data: {:?})", raw); | ||
| if log_enabled!(log::Level::Trace) { |
There was a problem hiding this comment.
We need to keep dumping the payload at debug level for now (this will be the level we run in prod testnet).
There was a problem hiding this comment.
why not just increase the verbosity of the prod testnet gateway using the -vvvv flag? the point of this change is to have ultra-verbose print-the-entire-100kb-contract-bytes at a different level than the lighter messages
There was a problem hiding this comment.
The problem is that we get a lot of unwanted stuff from a number other libraries at trace level. I would prefer to use debug rather than explicitly filtering out all of those libraries.
There was a problem hiding this comment.
okay, then how about we make this debug and make everything else info?
|
|
||
| // reset max log level to Info after default_app macro sets it to Trace | ||
| log::set_max_level(LevelFilter::Info); | ||
| log::set_max_level(match args.occurrences_of("v") { |
There was a problem hiding this comment.
We need to make sure that a corresponding change goes in to https://github.com/oasislabs/private-ops/blob/master/k8s/ekiden/templates/gateway.yaml to set the level to debug for testnet deployments.
2 participants
fixes #94