scroll container + back button fix #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirekys
reviewed
Jan 17, 2025
...nities_components/semantic-ui/less/oarepo_communities/themes/default/modules/modal.overrides
Outdated
Show resolved
Hide resolved
mirekys
reviewed
Jan 17, 2025
...nts/semantic-ui/js/communities_components/components/CommunitySelector/CommunitySelector.jsx
Show resolved
Hide resolved
mirekys
reviewed
Jan 17, 2025
...nts/semantic-ui/js/communities_components/components/CommunitySelector/CommunitySelector.jsx
Show resolved
Hide resolved
mirekys
reviewed
Jan 17, 2025
...nts/semantic-ui/js/communities_components/components/CommunitySelector/CommunitySelector.jsx
Show resolved
Hide resolved
|
mirekys
approved these changes
Jan 24, 2025
mirekys
deleted the
stojanovic/fe-297-community-selection-dialog-scrolling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to both https://linear.app/ducesnet/issue/FE-297/community-selection-dialog-scrolling and https://linear.app/ducesnet/issue/FE-298/community-selection-dialog-navigation. Please checkout and click through just to be sure. I would say it works as we would like.