Automatically build docker terraform image #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge repo oam-dev/docker-terraform-base into this repo and automatically build the image Signed-off-by: Zheng Xi Zhou <[email protected]>
lowkeyrd
reviewed
Jan 5, 2022
| LABEL org.label-schema.vcs-ref=$VCS_REF \ | ||
| org.label-schema.vcs-url="https://github.com/broadinstitute/docker-terraform" | ||
| RUN $RETRIEVE_TF_PROVIDER random 3.1.0 | ||
| RUN $RETRIEVE_TF_PROVIDER alicloud 1.140.0 |
There was a problem hiding this comment.
Maybe always use the newest version is better.
lowkeyrd
reviewed
Jan 5, 2022
| apk add --virtual=build gcc libffi-dev musl-dev openssl-dev python3-dev make && \ | ||
| apk add curl jq python3 ca-certificates git openssl unzip wget && \ | ||
| pip --no-cache-dir install -U pip && \ | ||
| pip install azure-cli && \ |
There was a problem hiding this comment.
When the provide is azurerm, it's needed.
lowkeyrd
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge repo oam-dev/docker-terraform-base into this repo and automatically
build the image
Signed-off-by: Zheng Xi Zhou [email protected]