This PR is going to handle the remaining "ansible-lint" version 6.0.0
violations for "disaster_recovery" & "remove_stale_lun" roles.
The follow-up commits will remove the specific per-type exclusions
and will fix the resulting "ansible-lint" violations, till the PR becomes
green and there are no per-type exclusions for the 2 roles.

Signed-off-by: Pavel Bar <[email protected]>
Bug-Url: https://bugzilla.redhat.com/2097332

No trailing spaces are allowed.
Fixing 1 violation:
  yaml: trailing spaces (yaml[trailing-spaces])

Signed-off-by: Pavel Bar <[email protected]>
Bug-Url: https://bugzilla.redhat.com/2097332

Adding the missing spaces before and after the "|" Jinja2 "default" filter.
Fixing 14 violations:
  var-spacing: Jinja2 variables and filters should have spaces before and after.

Signed-off-by: Pavel Bar <[email protected]>
Bug-Url: https://bugzilla.redhat.com/2097332

Adding the missing "pipefail" option.
Fixing 1 violation:
  risky-shell-pipe: Shells that use pipes should set the pipefail option.
Some code reformatting to increase readability.

Signed-off-by: Pavel Bar <[email protected]>
Bug-Url: https://bugzilla.redhat.com/2097332

1. Adding the missing tasks' names.
Fixing 31 violations:
  unnamed-task: All tasks should be named.
2. Fixing some names (i.e. typos, plural vs. single and vice versa).
3. Adding additional info to the names (like disk ID, VM name or Storage Domain name).
4. Some comments improvements.

Signed-off-by: Pavel Bar <[email protected]>
Bug-Url: https://bugzilla.redhat.com/2097332

FQCN stands for "Fully Qualified Collection Name".
Adding the missing "ansible.builtin." prefix.
Fixing 54 violations:
  fqcn-builtins: Use FQCN for builtin actions.

Signed-off-by: Pavel Bar <[email protected]>
Bug-Url: https://bugzilla.redhat.com/2097332

Adding the missing "changed_when" conditional.
Fixing 5 violations:
  no-changed-when: Commands should not change things if nothing needs doing.

Signed-off-by: Pavel Bar <[email protected]>
Bug-Url: https://bugzilla.redhat.com/2097332

This PR handled the remaining "ansible-lint" version 6.0.0
violations for "disaster_recovery" & "remove_stale_lun" roles.
The only thing that's left are "ignore-errors" *warnings*.
After some discussions those should be ignored.
The ".ansible-lint" file for default ignores will be added by mnecas.

Signed-off-by: Pavel Bar <[email protected]>
Bug-Url: https://bugzilla.redhat.com/2097332