Fix ovirtvmipsv4 when using attr (#596)

* Fix ovirtvmipsv4 when using attr * add changelog
oVirt · Oct 6, 2022 · 2cdb4fc · 2cdb4fc
1 parent efe985a
commit 2cdb4fc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/changelogs/fragments/597-ovirt_disk-add-read_only-param.yml b/changelogs/fragments/597-ovirt_disk-add-read_only-param.yml
@@ -0,0 +1,3 @@
+---
+bugfixes:
+  - Fix ovirtvmipsv4 when using attribute (https://github.com/oVirt/ovirt-ansible-collection/pull/596).
diff --git a/plugins/filter/ovirtvmip.py b/plugins/filter/ovirtvmip.py
@@ -71,8 +71,9 @@ def ovirtvmipv4(self, ovirt_vms, attr=None, network_ip=None):
     def ovirtvmipsv4(self, ovirt_vms, attr=None, network_ip=None):
         'Return list of IPv4 IPs'
         ips = self._parse_ips(ovirt_vms, lambda version: version == 'v4', attr)
-        resp = [ip for ip in ips if self.__address_in_network(ip, network_ip)]
-        return resp
+        if attr:
+            return dict((k, v) for k, v in ips.items() if self.__address_in_network(v, network_ip))
+        return filter(lambda x: self.__address_in_network(x, network_ip), ips)
 
     def ovirtvmipv6(self, ovirt_vms, attr=None, network_ip=None):
         'Return first IPv6 IP'