Skip to content

Conversation

@martyall
Copy link
Contributor

@martyall martyall commented Jan 29, 2025

This work completes the query feature and includes PRs #2972 and #2975

The goal is to be able to query data which is stored in encoded form (as field elements), using the binary indices of the original data

NOTE: The first commit diff is large, the rest are aiming to refactor that commit so should be more manageable

  • Add a query interface to query field encoded data
  • Add tests, including edge cases
  • Move UserData arbitrary instance to utils

@martyall martyall marked this pull request as ready for review January 30, 2025 18:35
@martyall martyall requested a review from Fizzixnerd January 30, 2025 19:56
@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 95.16908% with 10 lines in your changes missing coverage. Please review.

Project coverage is 76.93%. Comparing base (97ee9f7) to head (bd4a885).
Report is 52 commits behind head on master.

Files with missing lines Patch % Lines
saffron/src/utils.rs 95.09% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2974      +/-   ##
==========================================
+ Coverage   76.87%   76.93%   +0.06%     
==========================================
  Files         262      262              
  Lines       61445    61614     +169     
==========================================
+ Hits        47234    47401     +167     
- Misses      14211    14213       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dannywillems dannywillems merged commit 33482cb into master Feb 3, 2025
13 checks passed
@dannywillems dannywillems deleted the marc/query-saffron branch February 3, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants