Skip to content

Applying mask on the table ids #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dannywillems wants to merge 2 commits into from
Closed

Applying mask on the table ids #1242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aba52d7
Applying mask on the joint_lookup_table
dannywillems Sep 11, 2023
26651ab
Applying mask on the table ids
dannywillems Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 31 additions & 9 deletions kimchi/src/prover.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1358,18 +1358,40 @@ where
));

//~~ * add the combined table polynomial
let table_blinding = if lcs.runtime_selector.is_some() {
let runtime_comm = lookup_context.runtime_table_comm.as_ref().unwrap();
let table_blinding = {
let joint_combiner = lookup_context.joint_combiner.as_ref().unwrap();

let blinding = runtime_comm.blinders.unshifted[0];

PolyComm {
unshifted: vec![*joint_combiner * blinding],
shifted: None,
let mut t = G::ScalarField::zero();
let mut acc = G::ScalarField::one();
let table_width = index
.cs
.lookup_constraint_system
.as_ref()
.unwrap()
.configuration
.lookup_info
.max_joint_size;
// Adding one for the table IDs
for _i in 0..table_width + 1 {
t += acc;
// joint_combiner^i
acc *= joint_combiner;
}
if lcs.runtime_selector.is_some() {
let runtime_blinder = {
let runtime_comm = lookup_context.runtime_table_comm.as_ref().unwrap();
runtime_comm.blinders.unshifted[0]
};
PolyComm {
unshifted: vec![t + *joint_combiner * runtime_blinder],
shifted: None,
}
} else {
PolyComm {
unshifted: vec![t],
shifted: None,
}
}
} else {
non_hiding(1)
};

let joint_lookup_table = lookup_context.joint_lookup_table.as_ref().unwrap();
Expand Down
4 changes: 2 additions & 2 deletions kimchi/src/verifier_index.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,10 +184,10 @@ impl<G: KimchiCurve> ProverIndex<G> {
lookup_table: cs
.lookup_table8
.iter()
.map(|e| self.srs.commit_evaluations_non_hiding(domain, e))
.map(|e| mask_fixed(self.srs.commit_evaluations_non_hiding(domain, e)))
.collect(),
table_ids: cs.table_ids8.as_ref().map(|table_ids8| {
self.srs.commit_evaluations_non_hiding(domain, table_ids8)
mask_fixed(self.srs.commit_evaluations_non_hiding(domain, table_ids8))
}),
runtime_tables_selector: cs
.runtime_selector
Expand Down