Normalize the runtime table configuration to "custom" #1132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
approved these changes
Jul 19, 2023
Merged
Previously, we were considering two types of runtime table configurations, indexed and custom. Indexed where supposed to represent "standard" array access, using indexed from 0 to N, which can be easily represented as a "custom" runtime table configurations whose first columns is from 0 to N. It also simplifies the wasm binding as enum with structure values can not be represented using wasm-bindgen.
dannywillems
force-pushed
the
rb/wannabedevelop
branch
from
6aae916 to
9644f58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were considering two types of runtime table configurations, indexed and custom.
Indexed where supposed to represent "standard" array access, using indexed from 0 to N, which can be easily represented as a "custom" runtime table configurations whose first columns is from 0 to N.
It also simplifies the wasm binding as enum with structure values can not be represented using wasm-bindgen.