Archive node compatibility #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

adonagy merged 60 commits into develop from feat/archive-compatibility

Jan 27, 2025

Contributor

adonagy commented Dec 2, 2024 •

edited

Loading

closes #383

adonagy changed the title ~~Feat/archive compatibility~~ Archive node compatibility

tizoc reviewed

View reviewed changes

mina-p2p-messages/src/string.rs Outdated Show resolved Hide resolved

tizoc reviewed

View reviewed changes

node/common/src/service/archive.rs Show resolved Hide resolved

tizoc reviewed

View reviewed changes

node/common/src/service/archive.rs Outdated Show resolved Hide resolved

tizoc reviewed

View reviewed changes

node/common/src/service/archive.rs Outdated Show resolved Hide resolved

tizoc reviewed

View reviewed changes

docker-compose.archive.devnet.compare.yml Outdated Show resolved Hide resolved

tizoc reviewed

View reviewed changes

ledger/src/database/database_impl.rs Outdated Show resolved Hide resolved

tizoc reviewed

View reviewed changes

ledger/src/mask/mask_impl.rs Outdated Show resolved Hide resolved

tizoc reviewed

View reviewed changes

node/common/src/service/archive.rs Show resolved Hide resolved

adonagy force-pushed the feat/archive-compatibility branch from cbb24b3 to 81f9bda Compare

December 11, 2024 13:09

adonagy force-pushed the feat/archive-compatibility branch 4 times, most recently from 107a928 to c07fa11 Compare

January 13, 2025 10:01

adonagy marked this pull request as ready for review

January 13, 2025 10:01

adonagy requested review from sebastiencs and tizoc

January 13, 2025 10:01

tizoc reviewed

View reviewed changes

.github/workflows/archive.yaml Show resolved Hide resolved

tizoc reviewed

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

tizoc reviewed

View reviewed changes

ledger/src/bin/ledger.rs Outdated Show resolved Hide resolved

tizoc reviewed

View reviewed changes

mina-p2p-messages/src/v2/manual.rs Show resolved Hide resolved

tizoc reviewed

View reviewed changes

node/common/src/service/archive.rs Outdated Show resolved Hide resolved

tizoc reviewed

View reviewed changes

node/common/src/service/archive.rs Show resolved Hide resolved

tizoc reviewed

View reviewed changes

node/common/src/service/p2p.rs Show resolved Hide resolved

tizoc reviewed

View reviewed changes

node/src/ledger/ledger_service.rs Outdated Show resolved Hide resolved

tizoc reviewed

View reviewed changes

node/src/ledger/ledger_service.rs Outdated Show resolved Hide resolved

tizoc reviewed

View reviewed changes

node/src/service.rs Outdated Show resolved Hide resolved

Collaborator

tizoc commented Jan 13, 2025

General comment because it happens at many places in the diff: is passing the is_archive boolean around everywhere the best option? Since most of the time the value is false I would rather leave the current constructors as-is, and then either have an extra method that takes care of setting up the archive node requirements when called (not sure how viable it is, just an idea)

sebastiencs suggested changes

View reviewed changes

ledger/src/mask/mask_impl.rs Outdated Show resolved Hide resolved

ledger/src/scan_state/transaction_logic.rs Show resolved Hide resolved

ledger/src/database/database_impl.rs Outdated Show resolved Hide resolved

sebastiencs previously requested changes

View reviewed changes

ledger/src/database/database_impl.rs Outdated Show resolved Hide resolved

ledger/src/mask/mask_impl.rs Outdated Show resolved Hide resolved

Adrian Nagy added 22 commits

January 27, 2025 11:20


          fix: correct tokens_used

a79ccd3


          chore: remove vrf bench

28b4baa


          chore: update cargo lock

6ca2b78


          chore: Cargo.lock

8eddb9d


          refactor: remove debug prints

54796b5


          fix: Correct AccessedOrNot variant for fee payer

f9f643e


          Include everything archive realeted behind the --archive-address flag

a300ef6


          chore: fix clippy warnings

659aa0f


          refactor: create separate ledger Database constructor for archive mode

858b57a


          fix: remove unused token_owners methods

ea047bc


          chore: remove redundant time fn in log macro calls

e200f14


          fix: make token_owners map optional


          refactor: remove unnecessary sql and sqlx files

2e371d0


          chore: small fixes, cargo fmt

8e9de35


          fix: re-enable testing binary in image


          Add readme for archive

c2f5364


          Update compose files and archive tool

0e6c6c9


          chore: fix typo

e2df91c


          fix: Correct coinbase amount calculation

0a94dce

closes #581


          fix(wasm): only build the current archiver mechanism for native

2a68df5


          fix(wasm): add missing fields in web builder

fb1c689


          refactor: Remove is_archive in long call chains, use a global OnceLoc…

c56c227

…k instead

adonagy force-pushed the feat/archive-compatibility branch from e986937 to c56c227 Compare

January 27, 2025 10:22

Adrian Nagy added 2 commits

January 27, 2025 11:25


          chore: cargo fmt

1f7eaf3


          Reference the refactor issue for future FIXME(#1043)

bd078ee

tizoc approved these changes

View reviewed changes

adonagy dismissed sebastiencs’s stale review

January 27, 2025 12:55

Resolved


          chore: Add archive to changelog

938af0c

adonagy merged commit 88835eb into develop

11 checks passed

adonagy deleted the feat/archive-compatibility branch

January 27, 2025 12:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet