Ledger: use eval pt name instead of fst and snd #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially, it was used to reflect the OCaml code in `src/lib/pickles/plonk_checks`. However, I do think we have to change that as it makes the code more readable from a cryptography point of view.
dannywillems
force-pushed
the
dw/remove-usage-of-fst-and-use-point-name
branch
from
cfe85fe to
d539303
Compare
tizoc
approved these changes
Nov 12, 2024
Collaborator
tizoc
left a comment
tizoc
left a comment
There was a problem hiding this comment.
Maybe @sebastiencs wants to take a look, but to me the change looks trivial. LGTM
Member
Author
|
FWIW: @sebastiencs was next to me at DevCon when doing this PR. We were commenting on some aesthetic improvements of Pickles and OpenMina |
Collaborator
|
@dannywillems please go ahead and merge (with the approval you should already be able to do so) |
sebastiencs
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, it was used to reflect the OCaml code in
src/lib/pickles/plonk_checks. However, I do think we have to change that as it makes the code more readable from a cryptography point of view.