Fixed tests in connection discovery #578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xMimir
force-pushed
the
feat/fixed-tests
branch
4 times, most recently
from
3a668da to
29a28e8
Compare
0xMimir
changed the title
0xMimir
changed the title
0xMimir
force-pushed
the
feat/fixed-tests
branch
4 times, most recently
from
a63ef17 to
c16b6fe
Compare
tizoc
reviewed
Aug 12, 2024
0xMimir
force-pushed
the
feat/fixed-tests
branch
from
c16b6fe to
db93a14
Compare
0xMimir
force-pushed
the
feat/fixed-tests
branch
2 times, most recently
from
819e562 to
505782c
Compare
0xMimir
force-pushed
the
feat/fixed-tests
branch
from
505782c to
c6ada37
Compare
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed and completed test in
node/testing/src/scenarios/multi_node/connection_discovery.rs, test take about 20 minutes to run locally, but 40-ish minutes to run in CI.Removed async requests to OCaml graphql in
node/testing/src/node/ocaml/mod.rs, this is because calling these function panics, since callingreqwest::blocking::Client::new();panics.Rewrote
KademliaBootstraptest innode/testing/src/scenarios/p2p/kademlia.rsand removedIncomingFindNodetest, since these tests where only used for debugging during development of Kademlia layer, and added that test in CI.