Skip to content

CI: VRF unit tests run as part of unit-tests #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dannywillems merged 1 commit into from
Dec 1, 2025
+1 −44
Merged

CI: VRF unit tests run as part of unit-tests #1684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 1 addition & 31 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,36 +150,6 @@ jobs:
# - name: Run ledger tests
# run: make test-ledger

vrf-tests:
timeout-minutes: 20
runs-on: ubuntu-24.04
steps:
- name: Git checkout
uses: actions/checkout@v6

- name: Load versions
uses: ./.github/actions/load-versions

- name: Setup build dependencies
uses: ./.github/actions/setup-build-deps

- name: Use shared OCaml setting up steps
uses: ./.github/actions/setup-ocaml
with:
ocaml_version: ${{ env.OCAML_VERSION }}

- name: Setup Rust
uses: ./.github/actions/setup-rust
with:
toolchain: ${{ env.RUST_NIGHTLY_VERSION }}
cache-prefix: vrf-${{ env.CACHE_VERSION }}

- name: Build vrf tests
run: make build-vrf

- name: Run vrf tests
run: make test-vrf

p2p-tests:
timeout-minutes: 15
runs-on: ubuntu-24.04
Expand Down Expand Up @@ -302,7 +272,6 @@ jobs:
--exclude libp2p-rpc-behaviour \
--exclude node \
--exclude mina-node-account \
--exclude vrf \
Copy link
Copy Markdown
Collaborator

@richardpringle richardpringle Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this down to a comment at the bottom? Just helps us keep track of what's explicitly being run. Once we stop excluding most tests, we can delete the comment

Copy link
Copy Markdown
Contributor Author

@dannywillems dannywillems Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, and pushed forced.

--exclude mina-node-common \
--exclude mina-node-native \
--exclude mina-node-web \
Expand All @@ -319,6 +288,7 @@ jobs:
--exclude mina-archive-breadcrumb-compare \
--exclude webrtc-sniffer
# --exclude mina-tree
# --exclude vrf

account-tests:
timeout-minutes: 20
Expand Down
13 changes: 0 additions & 13 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,6 @@ build-tests-webrtc: ## Build tests for WebRTC
cp -a $$FILE target/release/tests/webrtc_$$NAME; \
done < tests.tsv

.PHONY: build-vrf
build-vrf: ## Build the VRF package
@cd vrf && cargo +$(NIGHTLY_RUST_VERSION) build --release --tests

.PHONY: build-wasm
build-wasm: ## Build WebAssembly node
@cd node/web && cargo +${NIGHTLY_RUST_VERSION} build \
Expand Down Expand Up @@ -318,11 +314,6 @@ test-p2p: ## Run P2P tests
test-release: ## Run tests in release mode
cargo test --release

.PHONY: test-vrf
test-vrf: ## Run VRF tests, requires nightly Rust
@cd vrf && cargo +$(NIGHTLY_RUST_VERSION) test --release -- \
-Z unstable-options --report-time

.PHONY: test-account
test-account: ## Run account tests
@cargo test -p mina-node-account
Expand Down Expand Up @@ -360,10 +351,6 @@ nextest-p2p: ## Run P2P tests with cargo-nextest
nextest-ledger: build-ledger ## Run ledger tests with cargo-nextest, requires nightly Rust
@cd ledger && cargo +$(NIGHTLY_RUST_VERSION) nextest run --release

.PHONY: nextest-vrf
nextest-vrf: ## Run VRF tests with cargo-nextest, requires nightly Rust
@cd vrf && cargo +$(NIGHTLY_RUST_VERSION) nextest run --release

# Docker build targets

.PHONY: docker-build-all
Expand Down
Loading