Skip to content

Frontend: remove leaderboard and firebase #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Frontend: remove leaderboard and firebase #1579

wants to merge 6 commits into from
+519 −8,099

Conversation

@dannywillems
Copy link
Member

@dannywillems dannywillems commented Oct 30, 2025 •
edited
Loading

Closes #1597 and #1599

@dannywillems dannywillems force-pushed the dw/frontend-leaderboard-removal branch 2 times, most recently from d492e25 to 993241e Compare October 30, 2025 18:23
@github-actions
Copy link

github-actions bot commented Oct 30, 2025 •
edited
Loading

✓ Code Reference Verification Passed

All code references in the documentation have been verified successfully!

Total references checked: 1
Valid references: 1

The documentation is in sync with the codebase on the develop branch.

@dannywillems dannywillems force-pushed the dw/frontend-leaderboard-removal branch from 993241e to 948ec2b Compare October 30, 2025 18:32
@dannywillems dannywillems force-pushed the dw/frontend-leaderboard-removal branch from 948ec2b to 305e64f Compare October 30, 2025 18:35
@dannywillems dannywillems changed the base branch from dw/remove-producer-dashboard to develop October 31, 2025 05:00
@dannywillems dannywillems force-pushed the dw/frontend-leaderboard-removal branch from 305e64f to e7211ff Compare October 31, 2025 05:00
@github-actions
Copy link

github-actions bot commented Oct 31, 2025 •
edited
Loading

OCaml Reference Validation Results

Repository: https://github.com/MinaProtocol/mina.git
Branch: compatible
Status: ✓ Validation passed

Click to see full validation output 
Checking OCaml references against https://github.com/MinaProtocol/mina.git (branch: compatible)
Fetching current commit from compatible...
Current OCaml commit: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5

Validating references...
========================
✓ VALID: ledger/src/account/account.rs -> src/lib/mina_base/account.ml L:201-224
  ⚠ STALE COMMIT: fc6be4c58091c761f827c858229c2edf9519e941 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2285-2285
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2351-2356
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2407
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:9-51
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:452-454
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/with_status.ml L:6-10
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:76-80
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:68-69
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/coinbase.ml L:17-21
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/transaction/transaction.ml L:8-11
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:34-48
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/stake_delegation.ml L:11-13
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:179-181
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:239-243
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:352-362
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)

Summary
=======
Total references found: 16
Valid references: 16
Invalid references: 0
Stale commits: 16

⚠ Warning: 16 reference(s) have stale commits
Run with --update to update them automatically

@dannywillems dannywillems force-pushed the dw/frontend-leaderboard-removal branch 5 times, most recently from f0f9df4 to 05859fe Compare October 31, 2025 14:14
@dannywillems dannywillems changed the title Frontend: remove leaderboard Frontend: remove leaderboard and firebase Oct 31, 2025
@dannywillems dannywillems force-pushed the dw/frontend-leaderboard-removal branch from 05859fe to e2bd890 Compare October 31, 2025 14:55
@dannywillems dannywillems linked an issue Nov 4, 2025 that may be closed by this pull request
Frontend: remove firebase dependency #1599
Open
@dannywillems dannywillems moved this to In Progress in Rust node Nov 4, 2025
@dannywillems dannywillems force-pushed the dw/frontend-leaderboard-removal branch from e2bd890 to 8dab070 Compare November 5, 2025 16:57
@dannywillems
Frontend: Remove Firebase and leaderboard-related code
c0deead 
Remove all Firebase dependencies and leaderboard functionality that
is no longer needed. This resolves TypeScript compilation errors
related to undefined Firebase configuration properties.

Changes:
- Removed Firebase configuration from environment files
- Removed Firebase imports and providers from app.config.ts
- Removed unused uptime-pill component reference from toolbar
- Removed showLeaderboard conditional from web-node file upload
- Removed Firebase debug token comment from main.ts
- Cleaned up unused Firebase npm dependencies

This fixes the 'Property firebase does not exist on type' error
in the frontend build.
@dannywillems
package.json: remove angular/fire
bd79178
@dannywillems
frontend: remove leftover of firebase, heartbeat and LB
b66074c
@dannywillems dannywillems force-pushed the dw/frontend-leaderboard-removal branch from ec25cd1 to b66074c Compare November 5, 2025 17:58
@dannywillems
frontend: remove Firebase deploy and heartbeat config
942b74b 
Remove the Firebase deploy make target and npm script, and remove the
heartbeat config from environment.ts. These are remaining Firebase-related
code that are no longer needed after removing Firebase dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@directcuteo directcuteo directcuteo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Rust node
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Frontend: remove firebase dependency Remove the leader dashboard on the frontend

3 participants

@dannywillems @directcuteo