Skip to content

Update OCaml reference verification dates #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update OCaml reference verification dates #1557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ledger/src/account/account.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,8 +1283,8 @@ pub struct PermsConst {
/// - Zero-knowledge application state and verification
///
/// OCaml reference: src/lib/mina_base/account.ml L:201-224
/// Commit: fc6be4c58091c761f827c858229c2edf9519e941
/// Last verified: 2025-10-13
/// Commit: 9845659db2f494b3eed90d5eb70ea1f51f437e16
/// Last verified: 2025-10-20
#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)]
#[serde(into = "v2::MinaBaseAccountBinableArgStableV2")]
#[serde(try_from = "v2::MinaBaseAccountBinableArgStableV2")]
Expand Down
12 changes: 6 additions & 6 deletions ledger/src/scan_state/transaction_logic/for_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,14 @@ impl PartialOrd for HashableCompressedPubKey {
}

/// OCaml reference: src/lib/transaction_logic/mina_transaction_logic.ml L:2285-2285
/// Commit: 5da42ccd72e791f164d4d200cf1ce300262873b3
/// Last verified: 2025-10-10
/// Commit: 9845659db2f494b3eed90d5eb70ea1f51f437e16
/// Last verified: 2025-10-20
#[derive(Debug)]
pub struct InitLedger(pub Vec<(Keypair, u64)>);

/// OCaml reference: src/lib/transaction_logic/mina_transaction_logic.ml L:2351-2356
/// Commit: 5da42ccd72e791f164d4d200cf1ce300262873b3
/// Last verified: 2025-10-10
/// Commit: 9845659db2f494b3eed90d5eb70ea1f51f437e16
/// Last verified: 2025-10-20
#[derive(Debug)]
pub struct TransactionSpec {
pub fee: Fee,
Expand All @@ -78,8 +78,8 @@ pub struct TransactionSpec {
}

/// OCaml reference: src/lib/transaction_logic/mina_transaction_logic.ml L:2407
/// Commit: 5da42ccd72e791f164d4d200cf1ce300262873b3
/// Last verified: 2025-10-10
/// Commit: 9845659db2f494b3eed90d5eb70ea1f51f437e16
/// Last verified: 2025-10-20
#[derive(Debug)]
pub struct TestSpec {
pub init_ledger: InitLedger,
Expand Down
28 changes: 14 additions & 14 deletions ledger/src/scan_state/transaction_logic/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ pub use transaction_union_payload::{
};

/// OCaml reference: src/lib/mina_base/transaction_status.ml L:9-51
/// Commit: 5da42ccd72e791f164d4d200cf1ce300262873b3
/// Last verified: 2025-10-08
/// Commit: 9845659db2f494b3eed90d5eb70ea1f51f437e16
/// Last verified: 2025-10-20
#[derive(serde::Serialize, serde::Deserialize, Debug, Clone, PartialEq, Eq)]
pub enum TransactionFailure {
Predicate,
Expand Down Expand Up @@ -234,8 +234,8 @@ impl Display for TransactionFailure {
}

/// OCaml reference: src/lib/mina_base/transaction_status.ml L:452-454
/// Commit: 5da42ccd72e791f164d4d200cf1ce300262873b3
/// Last verified: 2025-10-08
/// Commit: 9845659db2f494b3eed90d5eb70ea1f51f437e16
/// Last verified: 2025-10-20
#[derive(SerdeYojsonEnum, Debug, Clone, PartialEq, Eq)]
pub enum TransactionStatus {
Applied,
Expand All @@ -252,8 +252,8 @@ impl TransactionStatus {
}

/// OCaml reference: src/lib/mina_base/with_status.ml L:6-10
/// Commit: 5da42ccd72e791f164d4d200cf1ce300262873b3
/// Last verified: 2025-10-08
/// Commit: 9845659db2f494b3eed90d5eb70ea1f51f437e16
/// Last verified: 2025-10-20
#[derive(serde::Serialize, serde::Deserialize, Debug, Clone, PartialEq)]
pub struct WithStatus<T> {
pub data: T,
Expand Down Expand Up @@ -324,8 +324,8 @@ where
}

/// OCaml reference: src/lib/mina_base/fee_transfer.ml L:76-80
/// Commit: 5da42ccd72e791f164d4d200cf1ce300262873b3
/// Last verified: 2025-10-10
/// Commit: 9845659db2f494b3eed90d5eb70ea1f51f437e16
/// Last verified: 2025-10-20
#[derive(Debug, Clone, PartialEq)]
pub struct SingleFeeTransfer {
pub receiver_pk: CompressedPubKey,
Expand All @@ -351,8 +351,8 @@ impl SingleFeeTransfer {
}

/// OCaml reference: src/lib/mina_base/fee_transfer.ml L:68-69
/// Commit: 5da42ccd72e791f164d4d200cf1ce300262873b3
/// Last verified: 2025-10-10
/// Commit: 9845659db2f494b3eed90d5eb70ea1f51f437e16
/// Last verified: 2025-10-20
#[derive(Debug, Clone, PartialEq)]
pub struct FeeTransfer(pub(super) OneOrTwo<SingleFeeTransfer>);

Expand Down Expand Up @@ -432,8 +432,8 @@ impl CoinbaseFeeTransfer {
}

/// OCaml reference: src/lib/mina_base/coinbase.ml L:17-21
/// Commit: 5da42ccd72e791f164d4d200cf1ce300262873b3
/// Last verified: 2025-10-10
/// Commit: 9845659db2f494b3eed90d5eb70ea1f51f437e16
/// Last verified: 2025-10-20
#[derive(Debug, Clone, PartialEq)]
pub struct Coinbase {
pub receiver: CompressedPubKey,
Expand Down Expand Up @@ -1087,8 +1087,8 @@ impl GenericTransaction for Transaction {
/// [`MinaTransactionTransactionStableV2`].
///
/// OCaml reference: src/lib/transaction/transaction.ml L:8-11
/// Commit: 5da42ccd72e791f164d4d200cf1ce300262873b3
/// Last verified: 2025-10-10
/// Commit: 9845659db2f494b3eed90d5eb70ea1f51f437e16
/// Last verified: 2025-10-20
#[derive(Clone, Debug, derive_more::From)]
pub enum Transaction {
/// User-initiated transaction: signed command or zkApp command
Expand Down
20 changes: 10 additions & 10 deletions ledger/src/scan_state/transaction_logic/signed_command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ use super::{zkapp_command::AccessedOrNot, Memo, TransactionStatus};
/// Common fields shared by all signed command payloads.
///
/// OCaml reference: src/lib/mina_base/signed_command_payload.ml L:34-48
/// Commit: 5da42ccd72e791f164d4d200cf1ce300262873b3
/// Last verified: 2025-10-10
/// Commit: 9845659db2f494b3eed90d5eb70ea1f51f437e16
/// Last verified: 2025-10-20
#[derive(Debug, Clone, PartialEq)]
pub struct Common {
/// Fee paid to the block producer
Expand All @@ -43,8 +43,8 @@ pub struct PaymentPayload {
/// Stake delegation payload for delegating stake to another account.
///
/// OCaml reference: src/lib/mina_base/stake_delegation.ml L:11-13
/// Commit: 5da42ccd72e791f164d4d200cf1ce300262873b3
/// Last verified: 2025-10-10
/// Commit: 9845659db2f494b3eed90d5eb70ea1f51f437e16
/// Last verified: 2025-10-20
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum StakeDelegationPayload {
/// Delegate stake to a new delegate
Expand Down Expand Up @@ -76,8 +76,8 @@ impl StakeDelegationPayload {
/// delegation.
///
/// OCaml reference: src/lib/mina_base/signed_command_payload.ml L:179-181
/// Commit: 5da42ccd72e791f164d4d200cf1ce300262873b3
/// Last verified: 2025-10-10
/// Commit: 9845659db2f494b3eed90d5eb70ea1f51f437e16
/// Last verified: 2025-10-20
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum Body {
/// Transfer MINA tokens from fee payer to receiver
Expand All @@ -89,8 +89,8 @@ pub enum Body {
/// Signed command payload containing common fields and the transaction body.
///
/// OCaml reference: src/lib/mina_base/signed_command_payload.ml L:239-243
/// Commit: 5da42ccd72e791f164d4d200cf1ce300262873b3
/// Last verified: 2025-10-10
/// Commit: 9845659db2f494b3eed90d5eb70ea1f51f437e16
/// Last verified: 2025-10-20
#[derive(Debug, Clone, PartialEq)]
pub struct SignedCommandPayload {
/// Common fields (fee, fee payer, nonce, valid_until, memo)
Expand Down Expand Up @@ -122,8 +122,8 @@ impl SignedCommandPayload {
}

/// OCaml reference: src/lib/mina_base/signed_command_payload.ml L:352-362
/// Commit: 5da42ccd72e791f164d4d200cf1ce300262873b3
/// Last verified: 2025-10-10
/// Commit: 9845659db2f494b3eed90d5eb70ea1f51f437e16
/// Last verified: 2025-10-20
mod weight {
use super::*;

Expand Down
48 changes: 48 additions & 0 deletions validation_output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
Checking OCaml references against https://github.com/MinaProtocol/mina.git (branch: compatible)
Fetching current commit from compatible...
Current OCaml commit: 9845659db2f494b3eed90d5eb70ea1f51f437e16

Validating references...
========================
✓ VALID: ledger/src/account/account.rs -> src/lib/mina_base/account.ml L:201-224
⚠ STALE COMMIT: fc6be4c58091c761f827c858229c2edf9519e941 (current: 9845659db2f494b3eed90d5eb70ea1f51f437e16)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2285-2285
⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 9845659db2f494b3eed90d5eb70ea1f51f437e16)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2351-2356
⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 9845659db2f494b3eed90d5eb70ea1f51f437e16)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2407
⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 9845659db2f494b3eed90d5eb70ea1f51f437e16)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:9-51
⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 9845659db2f494b3eed90d5eb70ea1f51f437e16)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:452-454
⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 9845659db2f494b3eed90d5eb70ea1f51f437e16)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/with_status.ml L:6-10
⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 9845659db2f494b3eed90d5eb70ea1f51f437e16)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:76-80
⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 9845659db2f494b3eed90d5eb70ea1f51f437e16)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:68-69
⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 9845659db2f494b3eed90d5eb70ea1f51f437e16)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/coinbase.ml L:17-21
⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 9845659db2f494b3eed90d5eb70ea1f51f437e16)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/transaction/transaction.ml L:8-11
⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 9845659db2f494b3eed90d5eb70ea1f51f437e16)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:34-48
⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 9845659db2f494b3eed90d5eb70ea1f51f437e16)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/stake_delegation.ml L:11-13
⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 9845659db2f494b3eed90d5eb70ea1f51f437e16)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:179-181
⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 9845659db2f494b3eed90d5eb70ea1f51f437e16)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:239-243
⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 9845659db2f494b3eed90d5eb70ea1f51f437e16)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:352-362
⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 9845659db2f494b3eed90d5eb70ea1f51f437e16)

Summary
=======
Total references found: 16
Valid references: 16
Invalid references: 0
Stale commits: 16

⚠ Warning: 16 reference(s) have stale commits
Run with --update to update them automatically
Loading