Skip to content

CI: fix build-benches + add it in the workflow tests #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 5, 2025
Merged

CI: fix build-benches + add it in the workflow tests #1548

merged 7 commits into from
Nov 5, 2025
+47 −3

Conversation

@dannywillems
Copy link
Member

@dannywillems dannywillems commented Oct 15, 2025

No description provided.

@dannywillems dannywillems changed the title CI: fix build-benches + add it in the workflow tests. CI: fix build-benches + add it in the workflow tests Oct 15, 2025
@github-actions
Copy link

github-actions bot commented Oct 15, 2025 •
edited
Loading

OCaml Reference Validation Results

Repository: https://github.com/MinaProtocol/mina.git
Branch: compatible
Status: ✓ Validation passed

Click to see full validation output 
Checking OCaml references against https://github.com/MinaProtocol/mina.git (branch: compatible)
Fetching current commit from compatible...
Current OCaml commit: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5

Validating references...
========================
✓ VALID: ledger/src/account/account.rs -> src/lib/mina_base/account.ml L:201-224
  ⚠ STALE COMMIT: fc6be4c58091c761f827c858229c2edf9519e941 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2285-2285
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2351-2356
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2407
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:9-51
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:452-454
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/with_status.ml L:6-10
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:76-80
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:68-69
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/coinbase.ml L:17-21
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/transaction/transaction.ml L:8-11
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:34-48
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/stake_delegation.ml L:11-13
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:179-181
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:239-243
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:352-362
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: 918b8c0284a0d44bffeba8f6e2b1eb46ec33e9c5)

Summary
=======
Total references found: 16
Valid references: 16
Invalid references: 0
Stale commits: 16

⚠ Warning: 16 reference(s) have stale commits
Run with --update to update them automatically

@dannywillems dannywillems self-assigned this Oct 15, 2025
@dannywillems dannywillems moved this to In Progress in Rust node Oct 15, 2025
@dannywillems dannywillems requested a review from 0xMimir October 15, 2025 15:13
@github-actions
Copy link

github-actions bot commented Oct 15, 2025 •
edited
Loading

✓ Code Reference Verification Passed

All code references in the documentation have been verified successfully!

Total references checked: 1
Valid references: 1

The documentation is in sync with the codebase on the develop branch.

@dannywillems dannywillems force-pushed the dw/fix-build-benches branch 2 times, most recently from 738b7df to ad40910 Compare October 16, 2025 11:37
@dannywillems dannywillems force-pushed the dw/fix-build-benches branch 3 times, most recently from 32364f0 to 27d2834 Compare November 4, 2025 16:41
@dannywillems
CI/lint: formatting with new lines
1a5e7c6
@dannywillems
CI/workflow: build-reusable - setup SQLite for SQLx
e1398de
@dannywillems
CI/tests: run build-benches on ubuntu-22.04
83ada3d
@dannywillems
CHANGELOG: add description for patch 1548
6e6cff7
@dannywillems
CI: remove SQLite setup as not required anymore
670cef5
@dannywillems
CI: Add libpcap dependency for build-benches
0255d93 
Add libpcap-dev (Ubuntu) and libpcap (macOS) to build dependencies to fix
linking errors when building benchmarks. The webrtc-sniffer tool requires
the pcap library for packet capture functionality.
@dannywillems
Copy link
Member Author

dannywillems commented Nov 5, 2025

build-benches is fixed. I force merge the PR for the release.

@dannywillems dannywillems merged commit c383dc8 into develop Nov 5, 2025
68 of 71 checks passed
dannywillems added a commit that referenced this pull request Nov 5, 2025
@dannywillems
Merge pull request #1548 from o1-labs/dw/fix-build-benches
1b327a5 
CI: fix build-benches + add it in the workflow `tests`
@yamimaio yamimaio moved this from In Progress to Done in Rust node Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@directcuteo directcuteo directcuteo approved these changes

@0xMimir 0xMimir Awaiting requested review from 0xMimir

Assignees

@dannywillems dannywillems

Labels

None yet

Projects

Rust node
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dannywillems @directcuteo