Skip to content

Ledger/scan_state/tx-logic: split zkapp_command into submodules #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dannywillems merged 4 commits into from
Oct 13, 2025
Merged

Ledger/scan_state/tx-logic: split zkapp_command into submodules #1528

dannywillems merged 4 commits into from
Oct 13, 2025

Conversation

@dannywillems
Copy link
Member

@dannywillems dannywillems commented Oct 10, 2025

No description provided.

@dannywillems dannywillems force-pushed the dw/move-for-tests-transaction-logic branch from 6d510be to 67bb538 Compare October 10, 2025 10:06
@dannywillems dannywillems force-pushed the dw/split-zkapp-command-module branch from 8194a44 to c5c96fa Compare October 10, 2025 10:06
@dannywillems dannywillems force-pushed the dw/move-for-tests-transaction-logic branch from 67bb538 to d6b4773 Compare October 10, 2025 10:09
@dannywillems dannywillems force-pushed the dw/split-zkapp-command-module branch from c5c96fa to bb821ac Compare October 10, 2025 10:11
@github-actions
Copy link

github-actions bot commented Oct 10, 2025 •
edited
Loading

✓ Code Reference Verification Passed

All code references in the documentation have been verified successfully!

Total references checked: 1
Valid references: 1

The documentation is in sync with the codebase on the develop branch.

@dannywillems dannywillems force-pushed the dw/move-for-tests-transaction-logic branch from d6b4773 to 5e939f4 Compare October 10, 2025 10:11
@dannywillems dannywillems requested a review from 0xMimir October 10, 2025 10:15
@dannywillems dannywillems self-assigned this Oct 10, 2025
@dannywillems dannywillems moved this to Done in Rust node Oct 10, 2025
@dannywillems dannywillems force-pushed the dw/split-zkapp-command-module branch from bb821ac to 5dcd8d7 Compare October 10, 2025 10:16
@dannywillems dannywillems added the rust Pull requests that update Rust code label Oct 10, 2025
@dannywillems dannywillems force-pushed the dw/move-for-tests-transaction-logic branch from 5cfd6fc to 565d710 Compare October 13, 2025 09:04
@dannywillems dannywillems changed the base branch from dw/move-for-tests-transaction-logic to develop October 13, 2025 09:11
@dannywillems dannywillems force-pushed the dw/split-zkapp-command-module branch from e968980 to 03332a6 Compare October 13, 2025 09:11
@dannywillems dannywillems force-pushed the dw/split-zkapp-command-module branch from 03332a6 to 17f0fc8 Compare October 13, 2025 09:12
@github-actions
Copy link

github-actions bot commented Oct 13, 2025 •
edited
Loading

OCaml Reference Validation Results

Repository: https://github.com/MinaProtocol/mina.git
Branch: compatible
Status: ✓ Validation passed

Click to see full validation output 
Checking OCaml references against https://github.com/MinaProtocol/mina.git (branch: compatible)
Fetching current commit from compatible...
Current OCaml commit: 5da42ccd72e791f164d4d200cf1ce300262873b3
No OCaml references found in Rust code

@dannywillems dannywillems merged commit 5810609 into develop Oct 13, 2025
60 of 61 checks passed
@dannywillems dannywillems mentioned this pull request Oct 14, 2025
Open
6 tasks
@dannywillems dannywillems deleted the dw/split-zkapp-command-module branch October 16, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xMimir 0xMimir 0xMimir approved these changes

Assignees

@dannywillems dannywillems

Labels

rust Pull requests that update Rust code

Projects

Rust node
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dannywillems @0xMimir