Add Makefile #1150
Merged
Add Makefile #1150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
force-pushed
the
dw/add-makefile
branch
from
44af5d3 to
40e9590
Compare
dannywillems
force-pushed
the
dw/add-makefile
branch
from
40e9590 to
31c2511
Compare
dannywillems
force-pushed
the
dw/add-makefile
branch
from
335d007 to
8ed9f08
Compare
0xMimir
approved these changes
Jul 16, 2025
Contributor
0xMimir
left a comment
0xMimir
left a comment
There was a problem hiding this comment.
LGTM, but check comments
Comment on lines
+8
to
+13
| build: ## Build the project in debug mode | ||
| cargo build | ||
|
|
||
| .PHONY: build-release | ||
| build-release: ## Build the project in release mode | ||
| cargo build --release --bin openmina |
Contributor
There was a problem hiding this comment.
a small nitpick here, but build builds the entire project, while build-release builds only openmina executable
Member
Author
There was a problem hiding this comment.
Good point, lemme fix this.
Comment on lines
+20
to
+21
| build-wasm: ## Build WebAssembly node | ||
| cd node/web && cargo +nightly build --release --target wasm32-unknown-unknown |
Contributor
There was a problem hiding this comment.
This will build the openmina-node-web library but will not produce code needed to run the webnode for that following command should be used
wasm-pack build --target web --out-dir pkg
dannywillems
force-pushed
the
dw/add-makefile
branch
from
8ed9f08 to
5b121e9
Compare
dannywillems
force-pushed
the
dw/add-makefile
branch
from
5b121e9 to
a97c216
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to have a centralized reference for all the commands the CI runs, so the user can replicate exactly the CI behavior on their machine.