Skip to content

Fixed the issue with pending queue in yamux #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2025
Merged

Fixed the issue with pending queue in yamux #1040

merged 2 commits into from
Jan 31, 2025

Conversation

@0xMimir
Copy link
Contributor

@0xMimir 0xMimir commented Jan 27, 2025 •
edited
Loading

  • Changed window size logic so window size can increase more than 256kb
  • Changed logic with outgoing data to send packets with size 0
  • Changed logic to send window update after half our window is consumed instead of only 64kb being left

@0xMimir 0xMimir requested a review from vlad9486 January 27, 2025 11:35
tizoc
tizoc reviewed Jan 27, 2025
View reviewed changes
tizoc
tizoc reviewed Jan 27, 2025
View reviewed changes
@tizoc tizoc merged commit d64cdb7 into o1-labs:develop Jan 31, 2025
30 checks passed
@0xMimir 0xMimir deleted the bugfix/yamux-queue branch February 17, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tizoc tizoc tizoc left review comments

@vlad9486 vlad9486 Awaiting requested review from vlad9486

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0xMimir @tizoc