Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix padding bottom #27

Merged
merged 2 commits into from
Mar 6, 2018
Merged

Fix padding bottom #27

merged 2 commits into from
Mar 6, 2018

Conversation

manuelroth
Copy link
Contributor

@manuelroth manuelroth commented Mar 6, 2018 •
edited
Loading

@manuelroth manuelroth requested a review from benib March 6, 2018 15:40
benib
benib approved these changes Mar 6, 2018
View reviewed changes
Copy link
Contributor

@benib benib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice implementation!

@manuelroth manuelroth merged commit 0da03de into dev Mar 6, 2018
@manuelroth manuelroth deleted the fix-padding-bottom branch March 6, 2018 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benib benib benib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calculate padding-bottom for each image separately
2 participants
@manuelroth @benib