Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow copying of assets from custom repo #293

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

nzben
Copy link
Contributor

@nzben nzben commented Sep 8, 2021

Description of Change

Kia ora! New Library user here with one of two (hopefully) quick fixes.
First one: similar to issue #281, we'd like to deploy new images/icons as part of customisation. I've added a line to the build script to allow this.

Related Issue

#281

Checklist

  • Ran npm run lint and updated code style accordingly
  • npm run test passes
  • PR has a description and all contributors/stakeholder are noted/cc'ed
  • N/A tests are updated and/or added to cover new code
  • TODO relevant documentation is changed and/or added

Copy link
Member

@afischer afischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and should have been included originally! Thank you for the contribution.

@afischer afischer merged commit 97e76e4 into nytimes:main Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants