Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to crypto md5, remove md5 dependency #248

Merged
merged 2 commits into from
Feb 2, 2021
Merged

switch to crypto md5, remove md5 dependency #248

merged 2 commits into from
Feb 2, 2021

Conversation

afischer
Copy link
Member

@afischer afischer commented Jan 1, 2021

Description of Change

Removes the md5 dependency in favor of node's crypto module.

Related Issue

Closes #238.

Checklist

  • Ran npm run lint and updated code style accordingly
  • npm run test passes
  • PR has a description and all contributors/stakeholder are noted/cc'ed
  • tests are updated and/or added to cover new code
  • relevant documentation is changed and/or added [n/a]

@afischer afischer self-assigned this Jan 1, 2021
Copy link
Member

@isaacwhite isaacwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @afischer!

@isaacwhite isaacwhite changed the title witch to crypto md5, remove md5 dependency switch to crypto md5, remove md5 dependency Jan 1, 2021
@midorikocak
Copy link

Why PR's are not merged?

@afischer afischer merged commit 03925ed into master Feb 2, 2021
@afischer afischer deleted the no-md5 branch February 2, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove md5 dependency
3 participants