Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iOS 7 compatibility layer #84

Merged
merged 9 commits into from
Oct 30, 2015
Merged

Remove iOS 7 compatibility layer #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e3b7bf4
Set Example project to target iOS 8+
cdzombak Oct 19, 2015
74ca266
Set Podspec to require iOS 8+
cdzombak Oct 19, 2015
f1e8e31
Run `pod install` on Example app
cdzombak Oct 19, 2015
3399b71
Use new `UIActivityViewController.completionWithItemsHandler` API
cdzombak Oct 19, 2015
0ff8478
Merge branch 'develop' into cdz/68-deprecation
cdzombak Oct 19, 2015
0d08ed9
Remove NYTOperatingSystemCompatibilityUtility and its tests
cdzombak Oct 19, 2015
4884430
Remove OSCompatibilityUtility dependency from PhotoViewer code
cdzombak Oct 19, 2015
74036c6
Remove iOS 7-specific popover code paths
cdzombak Oct 19, 2015
bb4f90f
Update iOS version requirement in README
cdzombak Oct 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 2 additions & 34 deletions Example/NYTPhotoViewer.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,8 @@
B5DC9D871A9D326700F4F81F /* NYTPhotoViewControllerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = B5DC9D861A9D326700F4F81F /* NYTPhotoViewControllerTests.m */; };
B5DC9D891A9D35C500F4F81F /* NYTPhotoCaptionViewTests.m in Sources */ = {isa = PBXBuildFile; fileRef = B5DC9D881A9D35C500F4F81F /* NYTPhotoCaptionViewTests.m */; };
B5DC9D8B1A9F6C9800F4F81F /* NYTPhotosOverlayViewTests.m in Sources */ = {isa = PBXBuildFile; fileRef = B5DC9D8A1A9F6C9800F4F81F /* NYTPhotosOverlayViewTests.m */; };
B5DC9D8D1A9F771300F4F81F /* NYTOperatingSystemCompatibilityUtilityTests.m in Sources */ = {isa = PBXBuildFile; fileRef = B5DC9D8C1A9F771300F4F81F /* NYTOperatingSystemCompatibilityUtilityTests.m */; };
B5DC9D8F1A9F776100F4F81F /* NYTScalingImageViewTests.m in Sources */ = {isa = PBXBuildFile; fileRef = B5DC9D8E1A9F776100F4F81F /* NYTScalingImageViewTests.m */; };
B5DC9D911A9F793200F4F81F /* NYTPhotoTransitionAnimatorTests.m in Sources */ = {isa = PBXBuildFile; fileRef = B5DC9D901A9F793200F4F81F /* NYTPhotoTransitionAnimatorTests.m */; };
B5DC9D941A9FAB3900F4F81F /* NYTTestiOS7TransitionContext.m in Sources */ = {isa = PBXBuildFile; fileRef = B5DC9D931A9FAB3900F4F81F /* NYTTestiOS7TransitionContext.m */; };
B5DC9D971A9FAB4800F4F81F /* NYTTestiOS8TransitionContext.m in Sources */ = {isa = PBXBuildFile; fileRef = B5DC9D961A9FAB4800F4F81F /* NYTTestiOS8TransitionContext.m */; };
B5DC9D9A1A9FB0C000F4F81F /* NYTPhotosDataSourceTests.m in Sources */ = {isa = PBXBuildFile; fileRef = B5DC9D991A9FB0C000F4F81F /* NYTPhotosDataSourceTests.m */; };
C2764961179EFD3A4397B4F6 /* libPods-NYTPhotoViewer-Swift.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 3C25ACCAFE75703E4107C21D /* libPods-NYTPhotoViewer-Swift.a */; };
/* End PBXBuildFile section */
Expand Down Expand Up @@ -131,13 +128,8 @@
B5DC9D861A9D326700F4F81F /* NYTPhotoViewControllerTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = NYTPhotoViewControllerTests.m; sourceTree = "<group>"; };
B5DC9D881A9D35C500F4F81F /* NYTPhotoCaptionViewTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = NYTPhotoCaptionViewTests.m; sourceTree = "<group>"; };
B5DC9D8A1A9F6C9800F4F81F /* NYTPhotosOverlayViewTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = NYTPhotosOverlayViewTests.m; sourceTree = "<group>"; };
B5DC9D8C1A9F771300F4F81F /* NYTOperatingSystemCompatibilityUtilityTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = NYTOperatingSystemCompatibilityUtilityTests.m; sourceTree = "<group>"; };
B5DC9D8E1A9F776100F4F81F /* NYTScalingImageViewTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = NYTScalingImageViewTests.m; sourceTree = "<group>"; };
B5DC9D901A9F793200F4F81F /* NYTPhotoTransitionAnimatorTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = NYTPhotoTransitionAnimatorTests.m; sourceTree = "<group>"; };
B5DC9D921A9FAB3900F4F81F /* NYTTestiOS7TransitionContext.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NYTTestiOS7TransitionContext.h; sourceTree = "<group>"; };
B5DC9D931A9FAB3900F4F81F /* NYTTestiOS7TransitionContext.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = NYTTestiOS7TransitionContext.m; sourceTree = "<group>"; };
B5DC9D951A9FAB4800F4F81F /* NYTTestiOS8TransitionContext.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NYTTestiOS8TransitionContext.h; sourceTree = "<group>"; };
B5DC9D961A9FAB4800F4F81F /* NYTTestiOS8TransitionContext.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = NYTTestiOS8TransitionContext.m; sourceTree = "<group>"; };
B5DC9D991A9FB0C000F4F81F /* NYTPhotosDataSourceTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = NYTPhotosDataSourceTests.m; sourceTree = "<group>"; };
C260A188D0E255B25171088B /* README.md */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = net.daringfireball.markdown; name = README.md; path = ../README.md; sourceTree = "<group>"; };
C3A795E41A9CE3AA00A5AF55 /* NYTPhotoViewer.podspec */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; name = NYTPhotoViewer.podspec; path = ../NYTPhotoViewer.podspec; sourceTree = "<group>"; };
Expand Down Expand Up @@ -261,11 +253,9 @@
B5DC9D861A9D326700F4F81F /* NYTPhotoViewControllerTests.m */,
B5DC9D881A9D35C500F4F81F /* NYTPhotoCaptionViewTests.m */,
B5DC9D8A1A9F6C9800F4F81F /* NYTPhotosOverlayViewTests.m */,
B5DC9D8C1A9F771300F4F81F /* NYTOperatingSystemCompatibilityUtilityTests.m */,
B5DC9D8E1A9F776100F4F81F /* NYTScalingImageViewTests.m */,
B5DC9D901A9F793200F4F81F /* NYTPhotoTransitionAnimatorTests.m */,
B5DC9D991A9FB0C000F4F81F /* NYTPhotosDataSourceTests.m */,
B5DC9D981A9FAF6B00F4F81F /* Test Objects */,
6003F5B6195388D20070C39A /* Supporting Files */,
);
path = Tests;
Expand Down Expand Up @@ -344,17 +334,6 @@
name = "Common Resources";
sourceTree = "<group>";
};
B5DC9D981A9FAF6B00F4F81F /* Test Objects */ = {
isa = PBXGroup;
children = (
B5DC9D921A9FAB3900F4F81F /* NYTTestiOS7TransitionContext.h */,
B5DC9D931A9FAB3900F4F81F /* NYTTestiOS7TransitionContext.m */,
B5DC9D951A9FAB4800F4F81F /* NYTTestiOS8TransitionContext.h */,
B5DC9D961A9FAB4800F4F81F /* NYTTestiOS8TransitionContext.m */,
);
name = "Test Objects";
sourceTree = "<group>";
};
DC8AE5E7086B7FC6E4B5BE53 /* Pods */ = {
isa = PBXGroup;
children = (
Expand Down Expand Up @@ -677,14 +656,11 @@
files = (
B5DC9D831A9D062900F4F81F /* NYTExamplePhoto.m in Sources */,
B5DC9D911A9F793200F4F81F /* NYTPhotoTransitionAnimatorTests.m in Sources */,
B5DC9D971A9FAB4800F4F81F /* NYTTestiOS8TransitionContext.m in Sources */,
B5DC9D9A1A9FB0C000F4F81F /* NYTPhotosDataSourceTests.m in Sources */,
B5DC9D841A9D092200F4F81F /* NYTViewController.m in Sources */,
B5DC9D8F1A9F776100F4F81F /* NYTScalingImageViewTests.m in Sources */,
B5DC9D821A9D04D300F4F81F /* NYTPhotosViewControllerTests.m in Sources */,
B5DC9D871A9D326700F4F81F /* NYTPhotoViewControllerTests.m in Sources */,
B5DC9D941A9FAB3900F4F81F /* NYTTestiOS7TransitionContext.m in Sources */,
B5DC9D8D1A9F771300F4F81F /* NYTOperatingSystemCompatibilityUtilityTests.m in Sources */,
B5DC9D8B1A9F6C9800F4F81F /* NYTPhotosOverlayViewTests.m in Sources */,
B5DC9D891A9D35C500F4F81F /* NYTPhotoCaptionViewTests.m in Sources */,
);
Expand Down Expand Up @@ -817,7 +793,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 7.1;
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
ONLY_ACTIVE_ARCH = YES;
PRODUCT_NAME = NYTPhotoViewer;
SDKROOT = iphoneos;
Expand Down Expand Up @@ -851,7 +827,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 7.1;
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
PRODUCT_NAME = NYTPhotoViewer;
SDKROOT = iphoneos;
TARGETED_DEVICE_FAMILY = "1,2";
Expand All @@ -868,7 +844,6 @@
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "NYTPhotoViewer/NYTPhotoViewer-Prefix.pch";
INFOPLIST_FILE = "NYTPhotoViewer/NYTPhotoViewer-Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 7.0;
PRODUCT_BUNDLE_IDENTIFIER = "org.cocoapods.demo.${PRODUCT_NAME:rfc1034identifier}";
PRODUCT_NAME = NYTPhotoViewer;
WRAPPER_EXTENSION = app;
Expand All @@ -884,7 +859,6 @@
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "NYTPhotoViewer/NYTPhotoViewer-Prefix.pch";
INFOPLIST_FILE = "NYTPhotoViewer/NYTPhotoViewer-Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 7.0;
PRODUCT_BUNDLE_IDENTIFIER = "org.cocoapods.demo.${PRODUCT_NAME:rfc1034identifier}";
PRODUCT_NAME = NYTPhotoViewer;
WRAPPER_EXTENSION = app;
Expand All @@ -907,7 +881,6 @@
"$(inherited)",
);
INFOPLIST_FILE = "Tests/Tests-Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 7.0;
PRODUCT_BUNDLE_IDENTIFIER = "org.cocoapods.demo.${PRODUCT_NAME:rfc1034identifier}";
PRODUCT_NAME = Tests;
TEST_HOST = "$(BUNDLE_LOADER)";
Expand All @@ -927,7 +900,6 @@
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = "Tests/Tests-Prefix.pch";
INFOPLIST_FILE = "Tests/Tests-Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 7.0;
PRODUCT_BUNDLE_IDENTIFIER = "org.cocoapods.demo.${PRODUCT_NAME:rfc1034identifier}";
PRODUCT_NAME = Tests;
TEST_HOST = "$(BUNDLE_LOADER)";
Expand All @@ -950,7 +922,6 @@
"$(inherited)",
);
INFOPLIST_FILE = "NYTPhotoViewer-Swift/Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
MTL_ENABLE_DEBUG_INFO = YES;
PRODUCT_BUNDLE_IDENTIFIER = "com.nytimes.$(PRODUCT_NAME:rfc1034identifier)";
Expand All @@ -972,7 +943,6 @@
ENABLE_STRICT_OBJC_MSGSEND = YES;
GCC_NO_COMMON_BLOCKS = YES;
INFOPLIST_FILE = "NYTPhotoViewer-Swift/Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
MTL_ENABLE_DEBUG_INFO = NO;
PRODUCT_BUNDLE_IDENTIFIER = "com.nytimes.$(PRODUCT_NAME:rfc1034identifier)";
Expand Down Expand Up @@ -1000,7 +970,6 @@
"$(inherited)",
);
INFOPLIST_FILE = "NYTPhotoViewer-SwiftTests/Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
MTL_ENABLE_DEBUG_INFO = YES;
PRODUCT_BUNDLE_IDENTIFIER = "com.nytimes.$(PRODUCT_NAME:rfc1034identifier)";
Expand All @@ -1027,7 +996,6 @@
);
GCC_NO_COMMON_BLOCKS = YES;
INFOPLIST_FILE = "NYTPhotoViewer-SwiftTests/Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
MTL_ENABLE_DEBUG_INFO = NO;
PRODUCT_BUNDLE_IDENTIFIER = "com.nytimes.$(PRODUCT_NAME:rfc1034identifier)";
Expand Down
2 changes: 1 addition & 1 deletion Example/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ EXTERNAL SOURCES:
:path: "../"

SPEC CHECKSUMS:
NYTPhotoViewer: 9daf33d659ed5c4fabc3691f419a0aaf902c2c61
NYTPhotoViewer: d74401f7cf0b679a1763414d114eb5c81f5a1db8
OCMock: 28def049ef47f996b515a8eeea958be7ccab2dbb

COCOAPODS: 0.38.2
2 changes: 1 addition & 1 deletion Example/Pods/Local Podspecs/NYTPhotoViewer.podspec.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Example/Pods/Manifest.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading