Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dismiss bug created in commit c0c2040 #134

Closed
eeallen1 opened this issue Jan 18, 2016 · 0 comments
Closed

Dismiss bug created in commit c0c2040 #134

eeallen1 opened this issue Jan 18, 2016 · 0 comments
Assignees
@cdzombak
Labels
bug
Milestone
1.0.1

Comments

@eeallen1
Copy link

By swapping the logic to fix the previous dismissal bug to make interactive dismissals properly call the delegate methods in c0c2040, it looks like it created the same bug for dismissing via the X button in the top left of NYTPhotosViewController. Now, when I swipe to dismiss, the delegate DidDismiss or WillDismiss are called, but not when I click that button.
@cdzombak cdzombak reopened this Jan 19, 2016
@cdzombak cdzombak added this to the 1.0.1 milestone Jan 19, 2016
@cdzombak cdzombak self-assigned this Jan 19, 2016
@cdzombak cdzombak added the bug label Jan 19, 2016
@cdzombak cdzombak mentioned this issue Jan 19, 2016
Closed
cdzombak added a commit that referenced this issue Jan 19, 2016
@cdzombak
Track current dismissal is user-triggered; send delegate messages app…
eff4f08 
…ropriately

This follow-up to #130 fixes a bug wherein user-initiated dismissals
via the Close/X button didn’t send delegate messages about the
dismissal.

closes #134

I would welcome alternative fixes that do not require tracking
additional state.
@cdzombak cdzombak mentioned this issue Jan 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdzombak cdzombak

Labels
bug
Projects
None yet
Milestone
1.0.1
Development

No branches or pull requests
2 participants
@cdzombak @eeallen1