Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails of image files in the assets index are not displayed #359

Closed
mihob opened this issue Oct 26, 2022 · 8 comments
Closed

Thumbnails of image files in the assets index are not displayed #359

mihob opened this issue Oct 26, 2022 · 8 comments
Labels

Comments

@mihob
Copy link

mihob commented Oct 26, 2022

Describe the bug

Since version 4.3.0 of craft (the index pages have been reworked) the thumbnails in the assets index are no longer displayed when ImageOptimize is enabled. Only a generic icon of the file type is displayed. When Image Optimize is disabled, everything works as expected.

To reproduce

Steps to reproduce the behaviour:

  1. Go to "Assets"

Expected behaviour

Thumbnails of image files should be displayed

Screenshots

asset-index

Versions

  • Plugin version: 4.0.2
  • Craft version: Craft Pro 4.3.0
@mihob mihob added the bug label Oct 26, 2022
@khalwat
Copy link
Contributor

khalwat commented Oct 26, 2022

I will have a look; sounds like they changed something with regards to image transforms.

@mihob
Copy link
Author

mihob commented Oct 26, 2022

Yes, if I see it correctly, the bug does not only affect the asset index, at the moment no images are output at all.

@mihob
Copy link
Author

mihob commented Oct 27, 2022

Any news on this?

@mikewink
Copy link

I can confirm that issue. I ran into it after updating to Craft 4.3.0. All the images in the CP and frontend are gone. Disabling ImageOptimize brought back the images in the CP and the ones not optimized by the plugin.

Having a look at the changelog.md, there are two tickets (9622, 11970) directly tied to transforms.

@janhenckens
Copy link

Downgrading to 4.2.8 also fixed the issue for us

@thijskaspers
Copy link

Same here, Craft 4.3.0 + ImageOptimize breaks all image transforms (CP and front-end).

brandonkelly added a commit to craftcms/cms that referenced this issue Oct 27, 2022
@brandonkelly
Copy link

brandonkelly commented Oct 27, 2022

This was due to an unintended breaking change in 4.3.0, where Asset::getUrl() was respecting plugins which set $event->url = null, as ImageOptimize is doing (craftcms/cms@5c837e4).

Fixed for the next Craft 4 release (craftcms/cms@3f00b8d).

@brandonkelly
Copy link

Craft 4.3.1 has been released with the fix for ImageOptimize.

@khalwat khalwat closed this as completed Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants