Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebP Image variants not generated for jpgs whose file extension is all caps #277

Closed
richardcalahan opened this issue May 4, 2021 · 3 comments
Labels

Comments

@richardcalahan
Copy link

Describe the bug

Very odd one. I've tested in multiple environments against several images. Each time, if the image file extension is all caps, ie, image.JPG or image.JPEG, webp variants are skipped. Simply changing the name to image.jpg or image.jpeg and reuploading will allow proper variant creation.

To reproduce

Steps to reproduce the behaviour:

  1. Upload an asset to an imageOptimized volume with a file extension in all caps, ie, image.JPG
  2. Check for webp variants in the image optimize preview
  3. See broken image for all webp variants

Expected behaviour

Webp variants are viewable in the preview after the background queue finishes

Versions

  • Plugin version: 1.6.33
  • Craft version: 3.6.12.1
@khalwat
Copy link
Contributor

khalwat commented May 7, 2021

That's pretty interesting... will fix thx!

@juban
Copy link

juban commented May 11, 2021

Hi @khalwat

I can confirm that too.
Any image file extensions using caps (JPG, PNG, etc...) seems to be ignored from the webp processing.

khalwat pushed a commit that referenced this issue May 11, 2021
@khalwat
Copy link
Contributor

khalwat commented May 11, 2021

Fixed in 4822043

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-imageoptimize": "dev-develop as 1.6.34”,

Then do a composer clear-cache && composer update

@khalwat khalwat closed this as completed May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants