-
Notifications
You must be signed in to change notification settings - Fork 32
fix(tauri): react infinite render loop and kv types and js kv types #3823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
drop useDeferredValue, it seems to be the cause of this render loop switch to debounce mechanism
|
Where did you drop the |
|
@agentpietrucha it is |
Light copy update
|
@doums asked to hold off with merging this for now. |
|
Okay, thanks to @agentpietrucha for testing and pointing this out: Updated React to latest (including the hook fixes) fixed the infinite loop we were experiencing. |
Nodecomponent.Seems related to the usage of
useDeferredValue. I failed to understand why but when I dropuseDeferredValue(...)it fixes the issue. At least I was not able to reproduce.For performance optimization, switched to debounce to render the list while typing into the search input.
This also fix the scrollToNode while navigating back to the server list and focusing the previous focused node.
EDIT: updated react to latest version fixed the loop issue with
useDeferredValue-> rollbacked 1.This change is