Implement tagging #93
Conversation
|
Warning Rate Limit Exceeded@nylonee has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 6 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe project now supports tagging for Sonarr and Radarr, enabling dynamic content management through tags. This feature allows users to specify Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files ignored due to path filters (1)
src/test/resources/tag-response.jsonis excluded by:!**/*.json
Files selected for processing (12)
- docker/entrypoint.sh (1 hunks)
- src/main/scala/configuration/Configuration.scala (1 hunks)
- src/main/scala/configuration/ConfigurationRedactor.scala (1 hunks)
- src/main/scala/configuration/ConfigurationUtils.scala (7 hunks)
- src/main/scala/configuration/Keys.scala (1 hunks)
- src/main/scala/plex/PlexUtils.scala (1 hunks)
- src/main/scala/radarr/RadarrPost.scala (1 hunks)
- src/main/scala/radarr/RadarrUtils.scala (1 hunks)
- src/main/scala/sonarr/SonarrPost.scala (1 hunks)
- src/main/scala/sonarr/SonarrUtils.scala (1 hunks)
- src/test/scala/PlexTokenSyncSpec.scala (1 hunks)
- src/test/scala/configuration/ConfigurationUtilsSpec.scala (4 hunks)
Files skipped from review due to trivial changes (1)
- src/main/scala/plex/PlexUtils.scala
Additional comments: 18
src/main/scala/radarr/RadarrPost.scala (1)
- 3-10: Changes to
RadarrPostcorrectly introduce thetagsfield with appropriate default value and type.src/main/scala/sonarr/SonarrPost.scala (1)
- 10-11: Changes to
SonarrPostcorrectly introduce thetagsfield with appropriate default value and type.src/main/scala/configuration/Keys.scala (2)
- 12-12: Addition of
sonarrTagskey is correctly implemented.- 19-19: Addition of
radarrTagskey is correctly implemented.src/main/scala/configuration/ConfigurationRedactor.scala (2)
- 16-16: Inclusion of
sonarrTagIdsin the configuration output is correctly implemented.- 24-24: Inclusion of
radarrTagIdsin the configuration output is correctly implemented.src/main/scala/configuration/Configuration.scala (2)
- 22-23: Addition of
sonarrTagIdsfield toSonarrConfigurationis correctly implemented.- 31-32: Addition of
radarrTagIdsfield toRadarrConfigurationis correctly implemented.docker/entrypoint.sh (1)
- 86-92: Conditional inclusion of
SONARR_TAGSandRADARR_TAGSenvironment variables in the command array is correctly implemented.src/main/scala/radarr/RadarrUtils.scala (1)
- 30-30: Modification to
addToRadarrfunction to includetagsparameter inRadarrPostinstantiation is correctly implemented.src/main/scala/sonarr/SonarrUtils.scala (1)
- 38-38: Modification to include
tagsparameter inSonarrPostinstantiation is correctly implemented.src/test/scala/PlexTokenSyncSpec.scala (2)
- 44-45: Addition of
sonarrTagIdsto the test configuration for Sonarr is correctly implemented.- 52-53: Addition of
radarrTagIdsto the test configuration for Radarr is correctly implemented.src/main/scala/configuration/ConfigurationUtils.scala (5)
- 24-28: Modifications to
createfunction to includesonarrTagIdsandradarrTagIdsin configurations are correctly implemented.- 82-104: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [76-112]
Changes to
getSonarrConfigto handlesonarrTagIdsare correctly implemented.
- 115-141: Changes to
getRadarrConfigto handleradarrTagIdsare correctly implemented.- 144-159: Implementation of
getTagIdsFromConfigto fetch tag information is correctly implemented.- 261-267: Refactoring of
toArrto handle POST requests with payloads is correctly implemented.
| it should "fetch a tag from Sonarr/Radarr" in { | ||
|
|
||
| val mockConfigReader = createMockConfigReader(tags = Some("test-tag")) | ||
| val mockHttpClient = createMockHttpClient() | ||
|
|
||
| val config = ConfigurationUtils.create(mockConfigReader, mockHttpClient).unsafeRunSync() | ||
| noException should be thrownBy config | ||
| config.sonarrConfiguration.sonarrTagIds shouldBe Set(3) | ||
| config.radarrConfiguration.radarrTagIds shouldBe Set(3) | ||
| } |
There was a problem hiding this comment.
The test case "fetch a tag from Sonarr/Radarr" lacks assertions to verify the HTTP request details, such as the request path, method, and body. Adding these assertions would ensure that the correct API endpoints are called with the expected parameters.
Consider adding assertions to verify the HTTP request details to ensure the correctness of the API calls.
| (mockHttpClient.httpRequest _).expects( | ||
| Method.POST, | ||
| Uri.unsafeFromString("http://localhost:8989").withPath(Uri.Path.unsafeFromString("/api/v3/tag")), | ||
| Some("sonarr-api-key"), | ||
| * | ||
| ).returning(IO.pure(parse(Source.fromResource("tag-response.json").getLines().mkString("\n")))).anyNumberOfTimes() | ||
| (mockHttpClient.httpRequest _).expects( | ||
| Method.POST, | ||
| Uri.unsafeFromString("http://localhost:7878").withPath(Uri.Path.unsafeFromString("/api/v3/tag")), | ||
| Some("radarr-api-key"), | ||
| * | ||
| ).returning(IO.pure(parse(Source.fromResource("tag-response.json").getLines().mkString("\n")))).anyNumberOfTimes() |
There was a problem hiding this comment.
The wildcard matcher * used in the httpRequest mock setup for POST requests to Sonarr and Radarr tag APIs does not validate the request body. This could lead to false positives in tests if the request body format changes.
Replace the wildcard matcher with a specific matcher that validates the structure and content of the request body.
This closes #41
Summary by CodeRabbit
New Features
SONARR_TAGSandRADARR_TAGSenvironment variables to customize media management.Enhancements
Refactor
Tests