-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete series from Sonarr #77
Conversation
Warning Rate Limit Exceeded@nylonee has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 3 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the @coderabbitai review command. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates to Watchlistarr introduce the capability to fully sync with a user's watchlist, including the deletion of items that are no longer present. This feature, which is off by default, can be controlled with new environment variables. The codebase now includes adjustments across various Scala files to support this functionality, with changes to item deletion logic, case class fields, and method enhancements to enable the tracking and removal of content accordingly. Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit's AI:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (8)
- README.md (2 hunks)
- src/main/scala/PlexTokenDeleteSync.scala (2 hunks)
- src/main/scala/model/Item.scala (2 hunks)
- src/main/scala/plex/PlexUtils.scala (1 hunks)
- src/main/scala/radarr/RadarrConversions.scala (1 hunks)
- src/main/scala/sonarr/SonarrConversions.scala (1 hunks)
- src/main/scala/sonarr/SonarrSeries.scala (1 hunks)
- src/main/scala/sonarr/SonarrUtils.scala (2 hunks)
Additional comments: 13
src/main/scala/sonarr/SonarrConversions.scala (1)
- 5-10: The inclusion of the
ended
property fromSonarrSeries
toItem
creation in thetoItem
function is correctly implemented.src/main/scala/sonarr/SonarrSeries.scala (1)
- 3-9: The addition of
id
andended
fields to theSonarrSeries
case class is correctly implemented.src/main/scala/radarr/RadarrConversions.scala (1)
- 6-10: The addition of the
None
parameter to thetoItem
function call inRadarrConversions.scala
is correctly implemented to align with the newended
field in theItem
class.src/main/scala/model/Item.scala (3)
3-3: The addition of the
ended
field to theItem
case class with a default value ofNone
is correctly implemented.13-14: The new
getSonarrId
method in theItem
case class is correctly implemented to retrieve the Sonarr ID.16-20: The update to the
matches
method to include the newended
field in the pattern matching is correctly implemented.src/main/scala/PlexTokenDeleteSync.scala (2)
39-45: The modification in the control flow to call the
deleteSeries
method for "show" items instead of logging and returning a unit is correctly implemented.60-69: The addition of the new private method
deleteSeries
to handle the deletion of TV shows based on specific conditions is correctly implemented.src/main/scala/sonarr/SonarrUtils.scala (2)
52-63: The addition of the protected method
deleteFromSonarr
and its implementation using the newdeleteToArr
method is correctly implemented.65-73: The new private method
deleteToArr
inSonarrUtils.scala
is correctly implemented to perform the deletion of items from Sonarr.src/main/scala/plex/PlexUtils.scala (1)
- 162-162: The modification to include an additional parameter
ended
in the construction ofItem
instances within themap
function call is correctly implemented.README.md (2)
23-29: The documentation update in the
README.md
file to reflect the new full delete sync feature and how to enable it is correctly implemented.83-102: The addition of new environment variables
ALLOW_ENDED_SHOW_DELETING
andALLOW_CONTINUING_SHOW_DELETING
to control the behavior of the sync process is correctly documented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (8)
- README.md (2 hunks)
- src/main/scala/PlexTokenDeleteSync.scala (2 hunks)
- src/main/scala/model/Item.scala (2 hunks)
- src/main/scala/plex/PlexUtils.scala (1 hunks)
- src/main/scala/radarr/RadarrConversions.scala (1 hunks)
- src/main/scala/sonarr/SonarrConversions.scala (1 hunks)
- src/main/scala/sonarr/SonarrSeries.scala (1 hunks)
- src/main/scala/sonarr/SonarrUtils.scala (2 hunks)
Files skipped from review as they are similar to previous changes (8)
- README.md
- src/main/scala/PlexTokenDeleteSync.scala
- src/main/scala/model/Item.scala
- src/main/scala/plex/PlexUtils.scala
- src/main/scala/radarr/RadarrConversions.scala
- src/main/scala/sonarr/SonarrConversions.scala
- src/main/scala/sonarr/SonarrSeries.scala
- src/main/scala/sonarr/SonarrUtils.scala
Closes #17
Summary by CodeRabbit
New Features
Enhancements
Item
class to include an optional 'ended' field and improved ID retrieval method.Documentation
Refactor
Bug Fixes