-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP debug logs #163
Add HTTP debug logs #163
Conversation
WalkthroughIn the Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Application Client
participant HttpClient as HttpClient
participant Logger as SLF4J Logger
Client->>HttpClient: Send HTTP Request
HttpClient->>Logger: Log request start
HttpClient->>HttpClient: Make HTTP Request
HttpClient->>Logger: Log request end
HttpClient-->>Client: Return HTTP Response
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/main/scala/http/HttpClient.scala (2 hunks)
Additional comments not posted (3)
src/main/scala/http/HttpClient.scala (3)
12-12
: Approved import addition for logging.The import of
LoggerFactory
is correctly placed and follows Scala's convention for integrating logging.
18-18
: Logger instance correctly declared.The logger instance is declared as private and uses
getClass
to ensure it logs with the correct class context, which is a good practice in Scala for class-specific logging.
67-74
: Review the added logging statements.The debug logging before and after the HTTP request is appropriate. However, consider improving the log message format to include more context or differentiate the request and response more clearly.
[REFACTOR_SUGGESTion]- logger.debug(s"HTTP Request: ${requestWithPayload.toString()}") + logger.debug(s"HTTP Request - Method: ${method.name}, URL: ${url.toString}, Headers: ${requestWithPayload.headers}") - logger.debug(s"HTTP Response: $response") + logger.debug(s"HTTP Response - Status: ${response.status.code}, Body: ${response.asString}")
Description
Add debug logs for HTTP requests to better identify issues around requests we send to Plex and other services
Checklist
sbt scalafmtAll
Run (and optionallysbt scalafmtSbt
)Summary by CodeRabbit