Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link to Kleinstein theme in README.md #3350

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 35 additions & 41 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,48 +1,42 @@
# Nylas Mail Changelog

### 1.0.29 (2/21/2017)

- Fixes:

+ You can now click inline images in messages to open them
+ More IMAP errors have been identified as retryable, which means users will
see less errors when syncing an account
+ Improve performance of thread search indexing queries
+ Correctly catch Invalid Login errors when sending

- Development:

+ Developer bar in Worker window now shows single delta connection
+ More code converted to Javascript

### 1.0.28 (2/16/2017)

- nylas-mail:

+ [battery] Add BatteryStatusManager
+ fix(exports) Add backoff schedulers
+ feat(offline) Re add offline status notification
+ reafctor(scheduler): Move SearchIndexer -> SearchIndexScheduler
+ feat(backoff-scheduler): Add a backoff scheduler service

- K2:

+ [local-sync] :art: sync loop error handler
+ [sentry] Don't use breadcrumbs in dev mode
+ [cloud-api] remove latest_cursor endpoint
+ [cloud-api] Log error info on 5xx errors
+ [local-sync] Refresh Google OAuth2 tokens when Invalid Credentials occurs in sync loop
+ Add TODOs about retries in sending
+ [local-sync] Add exponential backoff when retrying syncback tasks
+ [SFDC] Update SalesforceSearchIndexer for new search indexing
+ [cloud-api,cloud-workers,local-sync] Bump hapi version
+ [cloud-api] Reduce request timing precision
+ Bump pm2 version to 2.4.0
+ [cloud-api] KEEP Timeout streaming API connections every 15 minutes
+ Revert [cloud-api] Timeout streaming API connections every 15 minutes
+ [cloud-\*] Properly listen to stream disconnect events to close redis connections
+ [cloud-core, cloud-api] add logging to delta connection
+ [cloud-api] Timeout streaming API connections every 15 minutes
+ [isomorphic-core] add accountId index definition to Transaction table
+ [cloud-api] recover from bad error from /n1/user
+ [local-sync] :art: comment
+ [local-sync] syncback(Part 5): Always keep retrying tasks if error is retryable
+ [local-sync] :fire: Message syncback tasks
+ [cloud-api] Change an extension from .js to .es6
+ [local-sync] syncback(Part 4): Don't always mark INPROGRESS tasks as failed at beginning of sync
+ [local-sync] syncback(Part 3): Fixup
+ [local-sync] syncback(Part 2): Reinstate send tasks back into the sync loop
+ [cloud-api] Add metadata tests
+ [local-sync, cloud-api] Add logic to handle thread metadata
+ [local-sync] syncback(Part 1): Refactor syncback-task-helpers
+ [iso-core] Detect more offline errors when sending
+ [local-sync] Add a better reason when waking sync for syncback
+ [local-sync] More retryable IMAP errors
- Fixes:

+ Fix offline notification bug that caused api outage
+ We now properly handle gmail auth token errors in the middle of the sync loop. This means less red boxes for users!
+ Less battery usage when initial sync has completed!
+ No more errors when saving sent messages to sent folders (`auth or accountId` errors)
+ No more `Lingering tasks in progress marked as failed errors`
+ Syncback tasks will continue retrying even after closing app
+ Syncback tasks retry more aggressively
+ Detect more offline errors when sending, sending is more reliable
+ Imap connection pooling (yet to land)
+ More retryable IMAP errors, means less red boxes for users
+ Offline notification now shows itself when we’re actually offline, shows countdown for next reconnect attempt

- Development:

+ More tests
+ Don't use breadcrumbs in dev mode
+ Add a better reason when waking sync for syncback in the logs
+ BackoffScheduler, BatteryManager added for reusability

### 1.0.27 (2/14/17)

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ The Nylas Mail user interface is styled using CSS, which means it's easy to modi
- [Monokai](https://github.com/dcondrey/n1-monokai)
- [Agapanthus](https://github.com/taniadaniela/n1-agapanthus)—Inbox-inspired theme
- [Stripe](https://github.com/oeaeee/n1-stripe)
- [Kleinstein] (https://github.com/diklein/Kleinstein)—Hide the account list sidebar
- [Kleinstein](https://github.com/diklein/Kleinstein)—Hide the account list sidebar
- [BoraBora](https://github.com/arimai/N1-BoraBora)
- [Honeyduke](https://github.com/arimai/n1-honeyduke)
- [Snow](https://github.com/Wattenberger/N1-snow-theme)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
Name=<%= productName %>
Comment=<%= description %>
GenericName=<%= productName %>
Exec=<%= linuxShareDir %>/nylas %U
Icon=nylas
Exec=/usr/bin/nylas-mail %U
Icon=nylas-mail
Type=Application
StartupNotify=true
StartupWMClass=<%= productName %>
Expand Down
115 changes: 0 additions & 115 deletions build/resources/linux/nylas.sh

This file was deleted.

38 changes: 19 additions & 19 deletions build/resources/linux/redhat/nylas.spec.in
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Version: <%= version %>
Release: 0.1%{?dist}
Summary: <%= description %>
License: GPLv3
URL: https://nylas.com/N1
URL: https://github.com/nylas/nylas-mail
AutoReqProv: no # Avoid libchromiumcontent.so missing dependency

requires: libgnome-keyring
Expand All @@ -12,29 +12,29 @@ requires: libgnome-keyring
<%= description %>

%install
mkdir -p %{buildroot}/usr/local/share/nylas
cp -r <%= contentsDir %>/* %{buildroot}/usr/local/share/nylas
mkdir -p %{buildroot}/usr/share/nylas-mail
cp -r <%= contentsDir %>/* %{buildroot}/usr/share/nylas-mail

mkdir -p %{buildroot}/usr/local/bin/
mkdir -p %{buildroot}/usr/bin/

cp <%= linuxAssetsDir %>/nylas.sh %{buildroot}/usr/local/bin/nylas
chmod 755 %{buildroot}/usr/local/bin/nylas
ln -s ../share/nylas-mail/nylas %{buildroot}/usr/bin/nylas-mail
chmod 755 %{buildroot}/usr/bin/nylas-mail

mkdir -p %{buildroot}/usr/local/share/applications/
mv nylas.desktop %{buildroot}/usr/local/share/applications/
mkdir -p %{buildroot}/usr/share/applications/
mv nylas-mail.desktop %{buildroot}/usr/share/applications/

for s in 16 32 64 128 256 512; do
mkdir -p %{buildroot}/usr/local/share/icons/hicolor/${s}x${s}/apps
cp -p <%= linuxAssetsDir %>/icons/${s}.png %{buildroot}/usr/local/share/icons/hicolor/${s}x${s}/apps/nylas.png
mkdir -p %{buildroot}/usr/share/icons/hicolor/${s}x${s}/apps
cp -p <%= linuxAssetsDir %>/icons/${s}.png %{buildroot}/usr/share/icons/hicolor/${s}x${s}/apps/nylas-mail.png
done

%files
/usr/local/bin/nylas
/usr/local/share/nylas
/usr/local/share/applications/nylas.desktop
/usr/local/share/icons/hicolor/16x16/apps/nylas.png
/usr/local/share/icons/hicolor/32x32/apps/nylas.png
/usr/local/share/icons/hicolor/64x64/apps/nylas.png
/usr/local/share/icons/hicolor/128x128/apps/nylas.png
/usr/local/share/icons/hicolor/256x256/apps/nylas.png
/usr/local/share/icons/hicolor/512x512/apps/nylas.png
/usr/bin/nylas-mail
/usr/share/nylas-mail
/usr/share/applications/nylas-mail.desktop
/usr/share/icons/hicolor/16x16/apps/nylas-mail.png
/usr/share/icons/hicolor/32x32/apps/nylas-mail.png
/usr/share/icons/hicolor/64x64/apps/nylas-mail.png
/usr/share/icons/hicolor/128x128/apps/nylas-mail.png
/usr/share/icons/hicolor/256x256/apps/nylas-mail.png
/usr/share/icons/hicolor/512x512/apps/nylas-mail.png
6 changes: 3 additions & 3 deletions build/tasks/installer-linux-task.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ module.exports = (grunt) => {
writeFromTemplate(specInFilePath, templateData)

// This populates nylas.desktop
const desktopInFilePath = path.join(linuxAssetsDir, 'nylas.desktop.in')
const desktopInFilePath = path.join(linuxAssetsDir, 'nylas-mail.desktop.in')
writeFromTemplate(desktopInFilePath, templateData)

const cmd = path.join('script', 'mkrpm')
Expand Down Expand Up @@ -92,14 +92,14 @@ module.exports = (grunt) => {
name: grunt.config('appJSON').name,
description: grunt.config('appJSON').description,
productName: grunt.config('appJSON').productName,
linuxShareDir: '/usr/share/nylas',
linuxShareDir: '/usr/share/nylas-mail',
arch: arch,
section: 'devel',
maintainer: 'Nylas Team <[email protected]>',
installedSize: installedSize,
}
writeFromTemplate(path.join(linuxAssetsDir, 'debian', 'control.in'), data)
writeFromTemplate(path.join(linuxAssetsDir, 'nylas.desktop.in'), data)
writeFromTemplate(path.join(linuxAssetsDir, 'nylas-mail.desktop.in'), data)

const icon = path.join('build', 'resources', 'nylas.png')
const cmd = path.join('script', 'mkdeb');
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "nylas",
"name": "nylas-mail",
"productName": "Nylas Mail",
"version": "1.0.28",
"description": "The best email app for people and teams at work",
Expand Down
20 changes: 10 additions & 10 deletions script/mkdeb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ TARGET="$TARGET_ROOT/nylas-$VERSION-$ARCH"

mkdir -m $FILE_MODE -p "$TARGET/usr"
mkdir -m $FILE_MODE -p "$TARGET/usr/share"
cp -r "$APP_CONTENTS_DIRECTORY" "$TARGET/usr/share/nylas"
cp -r "$APP_CONTENTS_DIRECTORY" "$TARGET/usr/share/nylas-mail"

mkdir -m $FILE_MODE -p "$TARGET/DEBIAN"
cp "$OUTPUT_PATH/control" "$TARGET/DEBIAN/control"
Expand All @@ -31,28 +31,28 @@ cp "$LINUX_ASSETS_DIRECTORY/debian/postinst" "$TARGET/DEBIAN/postinst"
cp "$LINUX_ASSETS_DIRECTORY/debian/postrm" "$TARGET/DEBIAN/postrm"

mkdir -m $FILE_MODE -p "$TARGET/usr/bin"
cp "$LINUX_ASSETS_DIRECTORY/nylas.sh" "$TARGET/usr/bin/nylas"
chmod +x "$TARGET/usr/bin/nylas"
ln -s "../share/nylas-mail/nylas" "$TARGET/usr/bin/nylas-mail"
chmod +x "$TARGET/usr/bin/nylas-mail"

mkdir -m $FILE_MODE -p "$TARGET/usr/share/applications"
cp "$OUTPUT_PATH/nylas.desktop" "$TARGET/usr/share/applications"
cp "$OUTPUT_PATH/nylas-mail.desktop" "$TARGET/usr/share/applications"

mkdir -m $FILE_MODE -p "$TARGET/usr/share/pixmaps"
cp "$ICON_FILE" "$TARGET/usr/share/pixmaps"
cp "$ICON_FILE" "$TARGET/usr/share/pixmaps/nylas-mail.png"

mkdir -m $FILE_MODE -p "$TARGET/usr/share/icons/hicolor"
for i in 256 128 64 32 16; do
mkdir -p "$TARGET/usr/share/icons/hicolor/${i}x${i}/apps"
cp "$LINUX_ASSETS_DIRECTORY/icons/${i}.png" "$TARGET/usr/share/icons/hicolor/${i}x${i}/apps/nylas.png"
cp "$LINUX_ASSETS_DIRECTORY/icons/${i}.png" "$TARGET/usr/share/icons/hicolor/${i}x${i}/apps/nylas-mail.png"
done

# Copy generated LICENSE.md to /usr/share/doc/nylas/copyright
mkdir -m $FILE_MODE -p "$TARGET/usr/share/doc/nylas"
cp "$TARGET/usr/share/nylas/LICENSE" "$TARGET/usr/share/doc/nylas/copyright"
# Copy generated LICENSE.md to /usr/share/doc/nylas-mail/copyright
mkdir -m $FILE_MODE -p "$TARGET/usr/share/doc/nylas-mail"
cp "$TARGET/usr/share/nylas-mail/LICENSE" "$TARGET/usr/share/doc/nylas-mail/copyright"

# Add lintian overrides
mkdir -m $FILE_MODE -p "$TARGET/usr/share/lintian/overrides"
cp "$ROOT/build/resources/linux/debian/lintian-overrides" "$TARGET/usr/share/lintian/overrides/nylas"
cp "$ROOT/build/resources/linux/debian/lintian-overrides" "$TARGET/usr/share/lintian/overrides/nylas-mail"

# Remove group write from all files
chmod -R g-w "$TARGET";
Expand Down
4 changes: 1 addition & 3 deletions script/mkrpm
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@ mkdir -p $RPM_BUILD_ROOT/RPMS
cp -r "$APP_CONTENTS_DIRECTORY/"* "$RPM_BUILD_ROOT/BUILD"
cp -r "$LINUX_ASSETS_DIRECTORY/icons" "$RPM_BUILD_ROOT/BUILD"
cp "$BUILD_DIRECTORY/nylas.spec" "$RPM_BUILD_ROOT/SPECS"
cp "$LINUX_ASSETS_DIRECTORY/nylas.sh" "$RPM_BUILD_ROOT/BUILD"
cp "$RPM_BUILD_ROOT/BUILD/nylas.sh" "$RPM_BUILD_ROOT/BUILD/nylas"
cp "$BUILD_DIRECTORY/nylas.desktop" "$RPM_BUILD_ROOT/BUILD"
cp "$BUILD_DIRECTORY/nylas-mail.desktop" "$RPM_BUILD_ROOT/BUILD"

rpmbuild -ba "$BUILD_DIRECTORY/nylas.spec"
cp $RPM_BUILD_ROOT/RPMS/$ARCH/nylas-*.rpm "$BUILD_DIRECTORY"
Expand Down
6 changes: 3 additions & 3 deletions src/browser/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,17 +56,17 @@ const setupErrorLogger = (args = {}) => {
const declareOptions = (argv) => {
const optimist = require('optimist');
const options = optimist(argv);
options.usage("Nylas Mail v" + (app.getVersion()) + "\n\nUsage: n1 [options]\n\nRun N1: The open source extensible email client\n\n`n1 --dev` to start the client in dev mode.\n\n`n1 --test` to run unit tests.");
options.usage("Nylas Mail v" + (app.getVersion()) + "\n\nUsage: nylas-mail [options]\n\nRun Nylas Mail: The open source extensible email client\n\n`nylas-mail --dev` to start the client in dev mode.\n\n`n1 --test` to run unit tests.");
options.alias('d', 'dev').boolean('d').describe('d', 'Run in development mode.');
options.alias('t', 'test').boolean('t').describe('t', 'Run the specified specs and exit with error code on failures.');
options.boolean('safe').describe('safe', 'Do not load packages from ~/.nylas-mail/packages or ~/.nylas/dev/packages.');
options.alias('h', 'help').boolean('h').describe('h', 'Print this usage message.');
options.alias('l', 'log-file').string('l').describe('l', 'Log all test output to file.');
options.alias('c', 'config-dir-path').string('c').describe('c', 'Override the path to the N1 configuration directory');
options.alias('c', 'config-dir-path').string('c').describe('c', 'Override the path to the Nylas Mail configuration directory');
options.alias('s', 'spec-directory').string('s').describe('s', 'Override the directory from which to run package specs');
options.alias('f', 'spec-file-pattern').string('f').describe('f', 'Override the default file regex to determine which tests should run (defaults to "-spec\.(coffee|js|jsx|cjsx|es6|es)$" )');
options.alias('v', 'version').boolean('v').describe('v', 'Print the version.');
options.alias('b', 'background').boolean('b').describe('b', 'Start N1 in the background');
options.alias('b', 'background').boolean('b').describe('b', 'Start Nylas Mail in the background');
return options;
};

Expand Down