Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow utf8 characters in git commit messages #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jobevers
Copy link

@jobevers jobevers commented Jul 5, 2016

Fixes #13

@msabramo
Copy link

msabramo commented Oct 31, 2016

Hmmm, I'm not seeing a problem when using git master. I did a commit with a Unicode snowman (U+2603) in the commit message:

[marca@marca-mac2 smbot2]$ git log -1 --oneline
84a40df Add ☃

[marca@marca-mac2 smbot2]$ rm -rf debian; make-deb && cat debian/rules
'debian' directory successfully placed at the root of your repository
#!/usr/bin/make -f

%:
    dh $@ --with python-virtualenv%

Am I not doing the right thing to reproduce the issue?

@msabramo
Copy link

OK, I reproduced it by removing 662c6aa, which worked around the problem.

I like this better. I would vote for reverting 662c6aa and merging this PR.

@jobevers
Copy link
Author

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants