🧽 Don't filter on is_test #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should only be deployed once nyaruka/rapidpro#2319 is deployed
nicpottier
approved these changes
Feb 15, 2019
rowanseymour
force-pushed
the
rowanseymour-patch-1
branch
3 times, most recently
from
17fd133 to
c590219
Compare
rowanseymour
force-pushed
the
rowanseymour-patch-1
branch
from
c590219 to
dc5af45
Compare
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=======================================
Coverage 77.36% 77.36%
=======================================
Files 1 1
Lines 190 190
=======================================
Hits 147 147
Misses 24 24
Partials 19 19
Continue to review full report at Codecov.
|
|
@nicpottier fixed the tests... diff is a bit shitty from removing a test contact and then moving all the ids up one |
nicpottier
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should only be deployed once nyaruka/rapidpro#2319 is deployed