Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use run status instead of is_active and exit_type #59

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Use run status instead of is_active and exit_type #59

merged 1 commit into from
Jan 6, 2022

Conversation

rowanseymour
Copy link
Member

No description provided.

rowanseymour
rowanseymour commented Jan 6, 2022
View reviewed changes
archives/runs.go
WHEN status = 'I' THEN 'interrupted'
WHEN status = 'X' THEN 'expired'
WHEN status = 'F' THEN 'failed'
ELSE NULL
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matches https://github.com/nyaruka/rapidpro/blob/ab98a58b04cf242605519a7c0704dcbca22b38ed/temba/api/v2/serializers.py#L915-L920

@rowanseymour rowanseymour mentioned this pull request Jan 6, 2022
Closed
@rowanseymour rowanseymour requested a review from norkans7 January 6, 2022 17:07
@rowanseymour rowanseymour merged commit 68a8b45 into main Jan 6, 2022
@rowanseymour rowanseymour deleted the use_run_status branch January 6, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norkans7 norkans7 norkans7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rowanseymour @norkans7