Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from flow to flow_id and from groups to group_ids for ES queries #1089

Merged
merged 2 commits into from
Apr 4, 2022

Conversation

rowanseymour
Copy link
Member

@rowanseymour rowanseymour commented Mar 22, 2022

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #1089 (dde8230) into main (7fe09d1) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1089      +/-   ##
==========================================
+ Coverage   87.60%   87.65%   +0.05%     
==========================================
  Files         256      257       +1     
  Lines       10742    10745       +3     
==========================================
+ Hits         9410     9419       +9     
+ Misses        916      913       -3     
+ Partials      416      413       -3     
Impacted Files Coverage Δ
contactql/es/query.go 87.41% <100.00%> (ø)
contactql/mock.go 100.00% <100.00%> (ø)
flows/engine/errors.go 100.00% <0.00%> (ø)
flows/engine/session.go 74.91% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe09d1...dde8230. Read the comment docs.

@rowanseymour rowanseymour changed the title Switch from flow to flow_id for ES queries Switch from flow to flow_id and from groups to group_ids for ES queries Apr 4, 2022
@rowanseymour rowanseymour merged commit 2463bbb into main Apr 4, 2022
@rowanseymour rowanseymour deleted the es_flow_id branch April 4, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant