Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional validation for urls #773

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Conversation

ericnewcomer
Copy link
Member

Fixes: #772

@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #773 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #773      +/-   ##
==========================================
+ Coverage   64.12%   64.17%   +0.05%     
==========================================
  Files         164      164              
  Lines        6087     6091       +4     
  Branches     1417     1418       +1     
==========================================
+ Hits         3903     3909       +6     
+ Misses       1751     1750       -1     
+ Partials      433      432       -1
Impacted Files Coverage Δ
...ponents/flow/routers/webhook/WebhookRouterForm.tsx 88.57% <100%> (ø) ⬆️
src/store/validators.ts 68.04% <100%> (+1.37%) ⬆️
src/components/flow/routers/webhook/helpers.ts 67.64% <0%> (+2.94%) ⬆️
src/components/simulator/helpers.ts 47.61% <0%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6797ba...89e3f94. Read the comment docs.

@nicpottier
Copy link
Contributor

So basically this is only doing URL validation in the cases where there are no expressions is that right?

@rowanseymour
Copy link
Member

Looks good - just need nyaruka/goflow#815 as well so that we handle invalid URLs gracefully in the engine

@ericnewcomer ericnewcomer merged commit ce46704 into master Dec 20, 2019
@ericnewcomer ericnewcomer deleted the conditional_url_validation branch December 20, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL validation doesn't allow certain expressions
3 participants