Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to s3x for attachments to get correct urls when using minio #766

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

rowanseymour
Copy link
Member

No description provided.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.83%. Comparing base (160c188) to head (1e0e7cd).

Files Patch % Lines
backends/rapidpro/backend.go 55.55% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #766      +/-   ##
==========================================
- Coverage   75.84%   75.83%   -0.01%     
==========================================
  Files         111      111              
  Lines       10477    10479       +2     
==========================================
+ Hits         7946     7947       +1     
- Misses       1804     1805       +1     
  Partials      727      727              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour requested a review from norkans7 July 29, 2024 15:50
@rowanseymour rowanseymour merged commit e4e95ef into main Jul 29, 2024
5 of 7 checks passed
@rowanseymour rowanseymour deleted the s3x branch July 29, 2024 16:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants