Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessarily writing send channel logs to the database #760

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

rowanseymour
Copy link
Member

We're currently writing channel log objects to the database that we shouldn't be.. channel logs are considered attached if they are referenced by a message, therefore don't need to be written to the database because they will be accessed via the message that has the UUID of the log so we can find it in S3.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.88%. Comparing base (2e65d7e) to head (5278572).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #760   +/-   ##
=======================================
  Coverage   75.87%   75.88%           
=======================================
  Files         111      111           
  Lines       10393    10394    +1     
=======================================
+ Hits         7886     7887    +1     
  Misses       1788     1788           
  Partials      719      719           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour merged commit 205b3a3 into main Jul 23, 2024
9 checks passed
@rowanseymour rowanseymour deleted the clog_attached_fix branch July 23, 2024 21:49
@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant